Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#46531 closed defect (bug) (fixed)

CSS line-height values should be unitless - widgets.css

Reported by: ianbelanger Owned by: audrasjb
Priority: normal Milestone: 5.3
Component: Widgets Version:
Severity: normal Keywords: has-patch good-first-bug commit
Cc: Focuses: ui, administration, coding-standards

Description

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers wp-admin/css/widgets.css

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.

Attachments (3)

46531.diff (934 bytes ) - added by ianbelanger 7 years ago.
46531.2.diff (1001 bytes ) - added by audrasjb 7 years ago.
Patch refresh
46531.3.diff (574 bytes ) - added by ianbelanger 7 years ago.
Refreshes and updates patch with more precise line-height calculations

Download all attachments as: .zip

Change History (8)

@ianbelanger
7 years ago

#1 @audrasjb
7 years ago

  • Owner changed from ianbelanger to audrasjb
  • Status assignedreviewing

@audrasjb
7 years ago

Patch refresh

#2 @audrasjb
7 years ago

  • Component GeneralWidgets
  • Keywords commit added; needs-testing removed
  • Milestone Awaiting Review5.2
  • Status reviewingaccepted

Thanks for the patch @ianbelanger
Patch tested, now refreshed and ready to go!

#3 @SergeyBiryukov
7 years ago

  • Resolutionfixed
  • Status acceptedclosed

In 45053:

CSS Coding Standards: Use unitless values for line-height in wp-admin/css/widgets.css.

Props ianbelanger, audrasjb.
Fixes #46531. See #44643.

@ianbelanger
7 years ago

Refreshes and updates patch with more precise line-height calculations

#4 @ianbelanger
7 years ago

  • Milestone 5.25.3
  • Resolution fixed
  • Status closedreopened

#5 @SergeyBiryukov
7 years ago

  • Resolutionfixed
  • Status reopenedclosed

In 45415:

CSS Coding Standards: Update unitless values for line-height in wp-admin/css/widgets.css with more precise calculations.

Props ianbelanger.
Fixes #46531.

Note: See TracTickets for help on using tickets.