Opened 17 years ago
Closed 17 years ago
#4654 closed defect (bug) (fixed)
permalink_single_rss needs a filter
Reported by: | joostdevalk | Owned by: | westi |
---|---|---|---|
Milestone: | 2.3 | Priority: | normal |
Severity: | normal | Version: | 2.3 |
Component: | Administration | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
summary says it all, you can't filter the output of permalink_single_rss
Attachments (2)
Change History (14)
#4
@
17 years ago
+1 to adding a filter specifically for the rss permalink output.
But why is it called permalink_single_rss() anyway? Wouldn't the_permalink_rss() make more sense? Suggest renaming this function and all the calls to it.
#5
@
17 years ago
- Owner set to westi
- Status changed from new to assigned
Adding the filter is obviously a no brainer as for renaming - it is a published template tag so we would need to retain the old version in deprecated.php for a while.
I'm not sure the rename is worth it.
What does everyone else think?
#6
@
17 years ago
I'm +1 for renaming, for consistnecies sake.
We use the the_xxx format almost everywhere, so we should do it here as well.
@
17 years ago
Deprecate permalink_single_rss, replace with the_permalink_rss. Also adds the_permalink_rss filter.
#8
@
17 years ago
Added my patch suggestion. Sorry for the excessive whitespace changes in the patch, there's a lot of whitespace at the end of lines that my editor removes whenever I edit a PHP file.
#10
@
17 years ago
- Keywords commit added
Wait for it. We sometimes use the 'commit' keyword, but I'm not sure if the developers use that or not.
#11
@
17 years ago
Otto42, could you deactivate that whitespace cleanup feature of your text editor before creating patches? I'm a big fan of cleanup, but when it's mixed in with functional changes, it makes it really hard to see what has changed. I'd rather have condensed functional diffs and then separate whitespace cleanup diffs.
And yes, I know I've been guilty of this too in the past. :-)
Patch