Uploaded images goes to wrong folder/date structure

[kartiks16]

Hello Team

All test are from fresh install, default theme, no settings change, no plugin…
"Organize my uploads into month- and year-based folders” option checked.

Images upload date: 17/03/2019
Single “Test Page” published date: 27/11/2018

In WordPress 4.7 – 4.7.13 – 4.8 – 4.8.9:

images uploaded from Media Library goes to …/2019/03 folder… RIGHT
images uploaded from single “Test Page” goes to …/2018/11 folder… RIGHT

In WordPress 4.9 – 4.9.10 – 5.0.4 – 5.1.1:

images uploaded from Media Library goes to …/2019/03 folder… RIGHT
images uploaded from single “Test Page” goes to …/2019/03 folder… WRONG!!!

From 4.9 version has anything changed in the way WordPress handles image uploads?
If YES, how to go back to the old way (thus images uploaded from single “Test Page” goes to “published date” folder… and not to “upload date” folder)?

Thanks!

[swissspidy]

This was a deliberate change made in 4.9, see #10752. Citing the commit message:

When media is uploaded to a post, the upload directory is set according to the date of the post, so that the media URLs in the post match when the post was published.

A page is a slightly different beast, pages often live for years, and are regularly updated to stay relevant. This change causes media uploaded to pages to use the upload date to determine the upload directory.

I don't know if there's an easy way to change the folder structure for uploads. What's your use case for that? Why is the changed structure a problem?

[kartiks16]

Hello @swissspidy

Thank you for replying and sharing your thoughts.

I understand in most of the cases maybe it won't impact much.

But what if someone manages a photographer’s site with thousands of photos and it is necessary to link the photos with the individual pages as a matter of order.

Do you think there is any workaround for this?

Waiting for your reply,

Thanks.

[maximo71]

Hello @swissspidy

First sorry for my english.

For my test in 4.9 to 5.1.1 version this is not true.
Also images uploaded to a previously published Post (as well as to a Media Library and to a Pages) use the upload date to determine the upload directory and not the date of the post.

Thanks.

[antpb]

Moving this into 6.2 for investigation. This seems fit for a filter to allow customization of the structure.

[antpb]

A bit late in the 6.2 cycle to confidently deliver this change, so this should be moved to 6.3 when possible.

[antpb]

Talking with @joedolson in the recent Media meeting he mentioned that we could add a filter to $time in _wp_handle_upload and pass the $post object as an argument. That should allow the previous behavior to be achieved.

[oglekler]

This ticket was discussed during the bug scrub, and it was decided to move it into 6.4 due to lack of patch, and also in the core-media meeting if was considered to be more an enhancement then a bug, so, I am changing the type as well, it should make this ticket which needs simple enough patch among the first ones to solve in the next milestone.

Props to @mukesh27

[oglekler]

This ticket needs to add a new filter, which is described in the comment:10.

The filter needs to be properly documented as other filters in the code, and because this is pure enhancement, it should be reviewed and committed before Beta 1 (for the 6.4 it is September 26). And this filter also needs to be covered by Unit test to unsure that it will stay and work. Examples of such tests can be found with previously added filters and actions.

[oglekler]

There is no patch and no time before Beta 1 to make and test one, so, I am moving this ticket into the 6.5 milestone.

[webcommsat]

Update from the bug scrub November 14, 2023:

• @rajinsharwar offered to work on a patch during the bug scrub.
• @oglekler suggested: It looks like it shouldn't be so difficult to add a filter to allow people to change the folder themselves). But it needs proper documenting as well as a new filter and check if one parameter or more should be passed.

[rajinsharwar]

Just wanted to clarify this thing,

Single Page published date: 14/11/2008
Today Date: 14/11/2023

Images uploaded from Media Library go to …/2023/11 folder
Images uploaded from Single Page go to …/2023/11 folder

Have we now decided to change that thing, and change the Folder, when images are uploaded to the Single Page, to the folder of ".../2008/11"? cc @antpb @joedolson