#46567 closed task (blessed) (fixed)
Run AJAX test group for multisite
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | needs-unit-tests has-patch needs-refresh |
Focuses: | multisite | Cc: |
Description
In the test suite, tests within the ajax
group are only run when explicitly passed as an argument in --group
. These are tested for single site installs, but not multisite.
Some recent tests added in [44909] are failing when running the --group ajax
tests on multisite because of how capabilities for those actions are mapped for multisite installs.
I am proposing to add phpunit -c tests/phpunit/multisite.xml --group ajax
to the test suite.
There is a patch on #43438 that fixes the failures associated with [44909], but there are several others that should also be fixed before this can be added.
Attachments (2)
Change History (17)
#3
@
6 years ago
- Summary changed from Run AJAX test gruoup for multisite to Run AJAX test group for multisite
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
6 years ago
#6
@
6 years ago
- Owner set to desrosj
- Status changed from new to assigned
46567.2.diff skips the failing tests on multisite. The next step would be to write tests that only run on multisite.
Worth noting, the Undefined index: file
notice is being caused because an error is returned by wp_upload_bits()
due to .txt
files being disallowed for security purposes.
This ticket was mentioned in Slack in #core by marybaum. View the logs.
6 years ago
#9
@
5 years ago
I've not looked closely at the patch, but is anything preventing you from landing this @desrosj ?
If there is could you please bump the milestone to 5.4, thanks
#10
@
5 years ago
- Keywords needs-refresh added
@netweb The patch needs to be refreshed to run the tests within the Docker environment on Travis. I actually started looking at this yesterday and did not get to finish the patch. I plan to punt early next week if I don't get a chance to return to it.
#11
@
5 years ago
- Milestone changed from 5.3 to Future Release
I am going to punt this for now. It's a test related ticket, so can be moved back whenever there is time to finish refreshing
This ticket was mentioned in PR #321 on WordPress/wordpress-develop by desrosj.
5 years ago
#12
Trac ticket: https://core.trac.wordpress.org/ticket/46567
Hi @desrosj I just wanted to provide test results to help this work move forward.
Once I applied the patch from #43438 all the privacy tests were corrected leaving a single error and 4 failures listed below;