WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

#46568 closed defect (bug) (fixed)

Twenty Seventeen: Table block th has black border in back-end, but not on front-end

Reported by: ianbelanger Owned by: ianbelanger
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch commit
Focuses: Cc:
PR Number:

Description

While testing the table block vs. the classic block containing a table in the Twenty Seventeen theme, I noticed that a table containing a th will have a black 1px border in the editor, but only the gray bottom-border on the front-end. See screenshot below

Attachments (4)

46568-table-block-back-end.PNG (21.6 KB) - added by ianbelanger 7 months ago.
Table block with th back-end
46568-table-block-front-end.PNG (21.3 KB) - added by ianbelanger 7 months ago.
Table block with th front-end
46568.diff (488 bytes) - added by ianbelanger 7 months ago.
Removes the black border from th's in the editor
46568-table-block-back-end-fixed.PNG (23.2 KB) - added by ianbelanger 7 months ago.
Showing table block th style is fixed after patch

Download all attachments as: .zip

Change History (9)

@ianbelanger
7 months ago

Table block with th back-end

@ianbelanger
7 months ago

Table block with th front-end

@ianbelanger
7 months ago

Removes the black border from th's in the editor

#1 @ianbelanger
7 months ago

  • Keywords has-patch commit added; good-first-bug removed
  • Owner set to ianbelanger
  • Status changed from new to assigned

@ianbelanger
7 months ago

Showing table block th style is fixed after patch

#2 @mukesh27
7 months ago

@ianbelanger confirm that 46568.diff​ fix that border issue in Twenty Seventeen.

#3 @ianbelanger
7 months ago

  • Milestone changed from Awaiting Review to Future Release

Thanks @mukesh27, this is all set to commit

#4 @ianbelanger
7 months ago

  • Milestone changed from Future Release to 5.2

#5 @SergeyBiryukov
7 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45051:

Twenty Seventeen: Make <th> styling in table block consistent between back end and front end.

Props ianbelanger.
Fixes #46568.

Note: See TracTickets for help on using tickets.