WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #46599, comment 4


Ignore:
Timestamp:
03/22/2019 01:18:23 PM (4 years ago)
Author:
afragen
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #46599, comment 4

    initial v1  
    11If we wish to keep the empty checks I would propose adding an additional test to ensure the variable is set to something. The empty test in the original was to allow for a plugin that didn’t have a header set to be valid.
    22
    3 It appears that this commit will stop any plugin that doesn’t have one of the `readme.txt` headers defined to fail. I’m not at my computer today so I can’t test. I would much rather see this reverted and figure out a better name in beta.
     3It appears that this commit will stop any plugin that doesn’t have one of the `readme.txt` headers defined to be unable to activate. I’m not at my computer today so I can’t test. I would much rather see this reverted and figure out a better name in beta.