get_pages() ignores `hierarchical' arg when a cache for a query hits

[reedom]

get_pages() in post.php will shortcut if a cache for a query hits.
In that case it misses a chance to call `get_page_children()' so that it results non-hierarchical-ordered page array.

representation

1. create some pages hierarchical.
2. place the attatched file test_get_pages_order.php in /wp_includes.
3. run the script from shell.

[foolswisdom]

Hi Reedom, please attach a patch vs trunk.

[reedom]

I missed to mention its background.

This problem occurs only when there is one or more 'the_pages' filters and any of them change order of `$pages' array.

[reedom]

Please test well since I haven't.

[DD32]

the get_page_children() call is before the wp_cache_set() call under current-day trunk, So i'm closing this ticket as invalid, as it should no longer be needed.