WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 weeks ago

#46600 new defect (bug)

Twenty Nineteen: Flex order on comment form causes contents of comment_form_after to appear above the form

Reported by: garrett-eclipse Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: needs-patch
Focuses: accessibility, css Cc:

Description

In the Twenty Nineteen theme the comment form design uses flexbox order CSS properties.

When contents are injected via the comment_form_after they're expected to appear below the form, for instance the Akisment privacy message. Due to the flex order the contents instead appears before the form.

Attaching screenshots

Attachments (2)

Screen Shot 2019-03-22 at 12.16.01 AM.png (77.5 KB) - added by garrett-eclipse 3 years ago.
Akismet content injected via comment_form_after appearing above comments form
Screen Shot 2019-03-22 at 12.16.24 AM.png (147.3 KB) - added by garrett-eclipse 3 years ago.
Inspect screen showing the dom and css affecting the content order.

Download all attachments as: .zip

Change History (3)

@garrett-eclipse
3 years ago

Akismet content injected via comment_form_after appearing above comments form

@garrett-eclipse
3 years ago

Inspect screen showing the dom and css affecting the content order.

#1 @sabernhardt
4 weeks ago

  • Focuses accessibility css added; ui removed
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

The order has been like this since the initial commit, so I do not understand why it was done this way. But making the visual order match the DOM is important, with or without the comment_form_after content.

Last edited 3 weeks ago by sabernhardt (previous) (diff)
Note: See TracTickets for help on using tickets.