WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #46600, comment 2


Ignore:
Timestamp:
01/13/2022 08:58:00 PM (3 years ago)
Author:
sabernhardt
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #46600, comment 2

    initial v1  
    11Adding a message also hides the "Leave a comment" heading, and [attachment:"46600.diff"] shows it again.
    22
    3 The patch uses a new class to stop using CSS flex, but any child theme with the old markup still would have those styles. And this new container is hidden in the print stylesheet.
     3The patch uses a new class to stop using CSS flex, but any child theme with the old markup still would have the older styles. And this new container is hidden in the print stylesheet.
    44
    5 The patch does not match the styles perfectly when no messages are added. The 1rem top margin for the short line above the heading does not apply (it's included in the wrapper's margin), though I'm not convinced that the extra space is necessary.
     5The patch does not match the styles perfectly when no messages are added. The `1rem` top margin for the short line above the heading does not apply (it's included in the wrapper's margin), though I'm not convinced that the extra space is necessary.