Opened 6 years ago
Closed 4 years ago
#46601 closed defect (bug) (fixed)
Twenty Nineteen: Add space between checkbox and text on for the cookies checkbox on comments
Reported by: | garrett-eclipse | Owned by: | johnbillion |
---|---|---|---|
Milestone: | 5.7 | Priority: | normal |
Severity: | normal | Version: | 5.0 |
Component: | Bundled Theme | Keywords: | has-patch commit |
Focuses: | ui, css | Cc: |
Description
Hello, minor aesthetic issue with the privacy cookie checkbox on comment forms. Seems there's no space between the checkbox and the text. Only seems to affect Twenty Nineteen
Attachments (4)
Change History (16)
#2
@
4 years ago
- Focuses css added
- Keywords needs-refresh added
- Milestone changed from Awaiting Review to 5.7
- Owner set to sabernhardt
- Status changed from new to accepted
Thanks for the patch! It still needs the style-rtl.css file when committing, though.
Other themes:
All bundled themes from Twenty Ten to Twenty Seventeen already have the same margin applied to the cookies acceptance checkbox. Twenty Twenty and Twenty Twenty-One both apply spacing to the label instead.
#3
@
4 years ago
- Keywords needs-refresh removed
It seems I can't create a patch including the style-rtl.css file either. So I uploaded a patch with only the SCSS, and both CSS files will need compiling.
This ticket was mentioned in Slack in #core by sabernhardt. View the logs.
4 years ago
This ticket was mentioned in Slack in #core by monikarao. View the logs.
4 years ago
#6
@
4 years ago
Please add Testing Information here to help us in Testing.
- What are the steps to reproduce the problem?
- Are there any testing dependencies such as a plugin or script?
- What is the expected behavior after applying the patch?
#7
@
4 years ago
If you can, test in both left-to-right and right-to-left languages.
Before applying patch:
- Make sure the "Allow people to submit comments on new posts" and "Show comments cookies opt-in checkbox" options are checked in the site's Discussion Settings.
- Activate the Twenty Nineteen theme.
- Click "View" link for a post that has comments enabled and open.
- Log out and refresh the page (or copy and paste the post URL in another browser).
- Scroll to the comments form and see that the checkbox lacks space between it and the first word.
After applying patch:
- Run build to compile stylesheets from the SCSS.
- Clear cache or open a new browser.
- View the same page as earlier and look at the checkbox spacing.
#8
@
4 years ago
Looks good on both RTL and LTR languages. There's a space between the checkbox and the text.
cookie consent needs spacing between text and checkbox