WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 6 months ago

#46601 closed defect (bug) (fixed)

Twenty Nineteen: Add space between checkbox and text on for the cookies checkbox on comments

Reported by: garrett-eclipse Owned by: johnbillion
Milestone: 5.7 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch commit
Focuses: ui, css Cc:

Description

Hello, minor aesthetic issue with the privacy cookie checkbox on comment forms. Seems there's no space between the checkbox and the text. Only seems to affect Twenty Nineteen

Attachments (4)

Screen Shot 2019-03-22 at 12.16.45 AM.png (21.0 KB) - added by garrett-eclipse 2 years ago.
cookie consent needs spacing between text and checkbox
46601.diff (1.0 KB) - added by mukesh27 2 years ago.
Patch that add space between checkbox and text in comment
2019-comment-form-checkbox-margin-chrome.jpg (21.9 KB) - added by sabernhardt 7 months ago.
margin added to checkbox input (with patch)
46601.scss.diff (524 bytes) - added by sabernhardt 6 months ago.
SCSS only, from the root directory

Download all attachments as: .zip

Change History (16)

@garrett-eclipse
2 years ago

cookie consent needs spacing between text and checkbox

@mukesh27
2 years ago

Patch that add space between checkbox and text in comment

#1 @mukesh27
2 years ago

  • Focuses ui added
  • Keywords has-patch added

#2 @sabernhardt
7 months ago

  • Focuses css added
  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 5.7
  • Owner set to sabernhardt
  • Status changed from new to accepted

Thanks for the patch! It still needs the style-rtl.css file when committing, though.

Other themes:
All bundled themes from Twenty Ten to Twenty Seventeen already have the same margin applied to the cookies acceptance checkbox. Twenty Twenty and Twenty Twenty-One both apply spacing to the label instead.

@sabernhardt
7 months ago

margin added to checkbox input (with patch)

@sabernhardt
6 months ago

SCSS only, from the root directory

#3 @sabernhardt
6 months ago

  • Keywords needs-refresh removed

It seems I can't create a patch including the style-rtl.css file either. So I uploaded a patch with only the SCSS, and both CSS files will need compiling.

This ticket was mentioned in Slack in #core by sabernhardt. View the logs.


6 months ago

This ticket was mentioned in Slack in #core by monikarao. View the logs.


6 months ago

#6 @monikarao
6 months ago

Please add Testing Information here to help us in Testing.

  • What are the steps to reproduce the problem?
  • Are there any testing dependencies such as a plugin or script?
  • What is the expected behavior after applying the patch?

#7 @sabernhardt
6 months ago

If you can, test in both left-to-right and right-to-left languages.

Before applying patch:

  1. Make sure the "Allow people to submit comments on new posts" and "Show comments cookies opt-in checkbox" options are checked in the site's Discussion Settings.
  2. Activate the Twenty Nineteen theme.
  3. Click "View" link for a post that has comments enabled and open.
  4. Log out and refresh the page (or copy and paste the post URL in another browser).
  5. Scroll to the comments form and see that the checkbox lacks space between it and the first word.

After applying patch:

  1. Run build to compile stylesheets from the SCSS.
  2. Clear cache or open a new browser.
  3. View the same page as earlier and look at the checkbox spacing.

#8 @Boniu91
6 months ago

Looks good on both RTL and LTR languages. There's a space between the checkbox and the text.

#9 @sabernhardt
6 months ago

  • Keywords commit added

@Boniu91 Thanks for testing! Marking for commit.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


6 months ago

#11 @johnbillion
6 months ago

  • Owner changed from sabernhardt to johnbillion
  • Status changed from accepted to assigned

#12 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 50365:

Twenty Nineteen: Add some space between the cookies checkbox and label in comment form.

Props sabernhardt, garrett-eclipse, mukesh27, monikarao, Boniu91.
Fixes #46601.

Note: See TracTickets for help on using tickets.