Remove documentation reference to global $wpdb in upgrade.php

[jayupadhyay01]

I've found Some Code Changes Require about Variable Defining.

[SergeyBiryukov]

Hi @jayupadhyay01, welcome to WordPress Trac! Thanks for the patch.

$wpdb is already available here via wp-load.php.

Per the ​documentation standards, the @global tag is meant to list PHP globals used within functions or methods.

Looking at other files in wp-admin, it seems like we don't generally document $wpdb in code that itself is in the global namespace. The standards don't say anything about it either.

So perhaps we should remove @global wpdb $wpdb here instead. Introduced in [32642].

@DrewAPicture, do you have an opinion on documenting globals outside of functions or methods?

[jayupadhyay01]

Document changes as per suggestion.

[jayupadhyay01]

Hi @SergeyBiryukov

As per your suggestion i have changed the document and Added another patch #46602(changes).diff, Please have a look and let me know if any further actions required?

[dswebsme]

Tested and confirmed that the updated patch #46602(changes).diff correctly addresses the issue by fixing the documentation. No functional code modified.

Ready for commit.

[desrosj]

Removing has-dev-note. This keyword should only be used for noting tickets that have had a developer note published to the ​Make WordPress Core website.

[SergeyBiryukov]

In 45233:

Docs: Remove @global tag for $wpdb from wp-admin/install.php and wp-admin/upgrade.php.

Per the documentation standards, the @global tag is meant to list PHP globals used within functions or methods.

The code in question uses the variable in global namespace, but does not explicitly declare it.

Props jayupadhyay01, dswebsme.
Fixes #46602.