Opened 6 years ago
Closed 6 years ago
#46611 closed defect (bug) (fixed)
Mobile menu icon in admin not displaying properly in 5.2-alpha
Reported by: | earnjam | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.2 | Priority: | normal |
Severity: | normal | Version: | 5.2 |
Component: | Administration | Keywords: | has-patch commit |
Focuses: | ui | Cc: |
Attachments (5)
Change History (15)
#2
@
6 years ago
@desrosj thanks for the feedback. I realized the icon unicode is not the same with auto-generated one. That's why the character looks like removed from the font.
I changed codepoints for the icon and created a merge request. Hopefully, I am not missing something else and these changes work.
#3
@
6 years ago
PR looks good, thanks @oztaser. That will fix this issue.
But it also helped uncover a few potential other issues, including email-alt2. Let's look at those separately. Let's coordinate in https://github.com/WordPress/dashicons/pull/349#issuecomment-476090036, would appreciate any help.
#4
@
6 years ago
I have opened https://github.com/WordPress/dashicons/pull/350 to address additional issues discovered as a result of this ticket.
Please help test that PR!
#6
@
6 years ago
- Keywords has-patch needs-testing added
46611.3.diff is a patch for the issue described above, and a few more backwards compatibility fixes:
buddicons-bbpress-logo (f12b)
was moved back to the correct location off477
editor-ltr (f129)
was moved back to the correct location off10c
editor-ltr
andeditor-rtl
had been switched. The arrows now point in the correct directions.email-alt2 (f10a)
was moved to the correct location off467
.
Also, these icons are restored:
menu-alt (f228)
camera-alt (f129)
edit-large (f327)
editor-distractionfree (f211)
update-alt (f113)
twitter-alt (f302)
text-page (f121)
plugins-checked (f485)
menu-alt3 (f349)
menu-alt2 (f329)
- Duplicate lock icon at location
(f315)
- Duplicate
editor-code
icon at location(f494)
Also, this icon is being added:
code-standards (f13a)
#7
@
6 years ago
Hi @desrosj. I tested your patch and everything looks good to me.
There is also a new icon added. I think we need duplicate one for backwards compatibility. Am I right?
arrow-up-duplicate (f143)
#8
@
6 years ago
- Keywords needs-testing removed
All looks good on Windows Chrome, Firefox, IE11 and Edge. @oztaser the arrow-up-duplicate
icon is there, @desrosj just forgot it on his list
Thanks for the patch @oztaser. Dashicons is managed externally in a repo on GitHub.
The font was recently updated to be generated with a new build process. Instead of changing the character in this stylesheet, we need to investigate why this character was removed from the font, and it needs to be added back for backwards compatibility.
I can work on this Monday, but feel free to investigate this before then if you’d like. Pinging @joen.