WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #46615, comment 9


Ignore:
Timestamp:
03/25/2019 06:10:22 AM (7 months ago)
Author:
dd32
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #46615, comment 9

    initial v1  
    99However, there's also the case of someone calling `download_url()` directly for a WordPress.org domain (or other signed domain) where that is also now likely to return an unexpected WP_Error.
    1010
    11 One options is to disable the signature verification for both `WP_Upgrader::download_package()` and `download_url()` by default as long as we're supporting a `softfail`. [attachment:"46615.2.diff"] does that (But it's mostly untested).
     11One options is to disable the signature verification for both `WP_Upgrader::download_package()` and `download_url()` by default as long as we're supporting a `softfail`. [attachment:"46615.2-2.diff"] does that (But it's mostly untested).