Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#46616 closed defect (bug) (fixed)

Site Health: false positive on Background Updates check

Reported by: audrasjb's profile audrasjb Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-screenshots has-patch site-health commit
Focuses: Cc:


It appears there is a false positive on test_wp_version_check_attached function.

WP auto updates are enabled on my local install, and I have this message:

A plugin has prevented updates by disabling wp_version_check().

Maybe related to #46615, but still a false positive.

Attachments (2)

Capture d’écran 2019-03-23 à 05.52.37.png (50.0 KB) - added by audrasjb 5 years ago.
46616.patch (1.7 KB) - added by Clorith 5 years ago.

Download all attachments as: .zip

Change History (12)

#1 @audrasjb
5 years ago

  • Keywords has-screenshots added
  • Milestone changed from Awaiting Review to 5.2

Pinging @Clorith

#2 @Clorith
5 years ago

Ahh yes, I see why this is happening, not related to #46615 it's just got to do with a missing load order since it's in wp-admin and not a plugin now, changing the update check URL to request data from wp-admin/site-health.php will likely solve this, I'll get it sorted today along with some other task stuff on the original ticket at #46573

5 years ago

#3 @Clorith
5 years ago

  • Keywords has-patch added

46616.patch makes the check for the wp_version_check filter check the wp-admin/site-health.php page, instead of just the dashboard, and we test to see if we are checking for this filter in that file.

#4 @Clorith
5 years ago

  • Keywords site-health added

#5 @audrasjb
5 years ago

Hi @Clorith
Ok I see the missing load order, thanks for the explanation :)
I tested the patch and it works fine on my side, thanks!

#6 @Clorith
5 years ago

#46688 was marked as a duplicate.

#7 @Clorith
5 years ago

  • Keywords commit added

#8 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45049:

Site Health: Correct wp_version_check() existence verification by performing a request to the Site Health page instead of Dashboard.

Props Clorith, audrasjb.
Fixes #46616.

#9 @knutsp
5 years ago

#46814 was marked as a duplicate.

#10 @spacedmonkey
5 years ago

  • Component changed from General to Site Health
Note: See TracTickets for help on using tickets.