Site Health: The successful HTTPS check has no description.

[xkon]

While we do have descriptions when HTTPS checks will fail to guide users, the successful one currently only has a title.

Can we add a small text even with ​https://wordpress.org/support/article/why-should-i-use-https/ again just to have something in the accordion area?

It doesn't feel right when opening everything else reading the descriptions again and this one is missing it.

The description on success can be added along it's label and status siblings at class-wp-site-health.php - Line 1244

cc @Clorith , @karmatosed , @melchoyce

[xkon]

preview

[Clorith]

46617.patch​ sets up a default text, and also adds the link to the "Why should I use HTTPS?" as a persistent action item for this test.

[xkon]

Just patched this and it looks good to me !

[Clorith]

46617.2.patch​ is basically the same, but as there's now multiple actions it addresses a styling issue with multi-actions in the same go.

[xkon]

46617.3 preview

[xkon]

adds the missing .button class

[xkon]

@Clorith following your lead from the 46617.2.patch​ I've added the missing button classes from the <a> actions in 46617.3.diff​ .

[Clorith]

46617.2.patch​ is the one we should go with here. We want to avoid designing links as buttons when they are, in fact, links to other pages.

This follows the blessed task of #26504 of making sure buttons and links are what they claim to be.

[SergeyBiryukov]

Replying to Clorith:

46617.2.patch​ is the one we should go with here. We want to avoid designing links as buttons when they are, in fact, links to other pages.

46617.2.patch​ doesn't quite work, as the CSS changes refer to the missing .button class on the links, so there's no margin between them, see 46617.2.png​.

Initially, I wanted the links to be consistent with "Learn more about updating PHP" above, but I guess we should not add more links that open in a new tab.

I think they look better as separate paragraphs instead, see 46617.links.png​. This is consistent with links to Codex and Support under the Help tab on other admin screens.

[xkon]

Oh sorry, I saw that the links didn't have a space between them as in 46617.2.png​ and also the body .health-check-accordion .health-check-accordion-panel .actions .button on the previous patch and thought they were missed from the <a>. Got a bit confused from the classes there :D

[SergeyBiryukov]

In 45052:

Site Health: Add description for a successful HTTPS check.

Props Clorith, xkon.
Fixes #46617.