WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#46617 closed defect (bug) (fixed)

Site Health: The successful HTTPS check has no description.

Reported by: xkon Owned by: SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-screenshots has-patch site-health commit
Focuses: ui Cc:

Description

While we do have descriptions when HTTPS checks will fail to guide users, the successful one currently only has a title.

Can we add a small text even with https://wordpress.org/support/article/why-should-i-use-https/ again just to have something in the accordion area?

It doesn't feel right when opening everything else reading the descriptions again and this one is missing it.

The description on success can be added along it's label and status siblings at class-wp-site-health.php - Line 1244

cc @Clorith , @karmatosed , @melchoyce

Attachments (7)

https_pass_no_info.gif (284.7 KB) - added by xkon 3 years ago.
preview
46617.patch (2.3 KB) - added by Clorith 3 years ago.
46617.2.patch (2.8 KB) - added by Clorith 3 years ago.
1553592892.jpg (61.9 KB) - added by xkon 3 years ago.
46617.3 preview
46617.3.diff (2.9 KB) - added by xkon 3 years ago.
adds the missing .button class
46617.2.png (24.4 KB) - added by SergeyBiryukov 3 years ago.
46617.links.png (8.8 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (19)

@xkon
3 years ago

preview

@Clorith
3 years ago

#1 @Clorith
3 years ago

  • Keywords has-patch added; 2nd-opinion removed

46617.patch sets up a default text, and also adds the link to the "Why should I use HTTPS?" as a persistent action item for this test.

#2 @xkon
3 years ago

Just patched this and it looks good to me !

#3 @Clorith
3 years ago

  • Keywords site-health added

@Clorith
3 years ago

#4 @Clorith
3 years ago

46617.2.patch is basically the same, but as there's now multiple actions it addresses a styling issue with multi-actions in the same go.

@xkon
3 years ago

46617.3 preview

@xkon
3 years ago

adds the missing .button class

#5 @xkon
3 years ago

@Clorith following your lead from the 46617.2.patch I've added the missing button classes from the <a> actions in 46617.3.diff .

#6 @pento
3 years ago

  • Type changed from enhancement to defect (bug)

#7 follow-up: @Clorith
3 years ago

  • Keywords commit added

46617.2.patch is the one we should go with here. We want to avoid designing links as buttons when they are, in fact, links to other pages.

This follows the blessed task of #26504 of making sure buttons and links are what they claim to be.

#8 @SergeyBiryukov
3 years ago

  • Component changed from General to Administration

#9 in reply to: ↑ 7 @SergeyBiryukov
3 years ago

Replying to Clorith:

46617.2.patch is the one we should go with here. We want to avoid designing links as buttons when they are, in fact, links to other pages.

46617.2.patch doesn't quite work, as the CSS changes refer to the missing .button class on the links, so there's no margin between them, see 46617.2.png.

Initially, I wanted the links to be consistent with "Learn more about updating PHP" above, but I guess we should not add more links that open in a new tab.

I think they look better as separate paragraphs instead, see 46617.links.png. This is consistent with links to Codex and Support under the Help tab on other admin screens.

#10 @xkon
3 years ago

Oh sorry, I saw that the links didn't have a space between them as in 46617.2.png and also the body .health-check-accordion .health-check-accordion-panel .actions .button on the previous patch and thought they were missed from the <a>. Got a bit confused from the classes there :D

#11 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45052:

Site Health: Add description for a successful HTTPS check.

Props Clorith, xkon.
Fixes #46617.

#12 @spacedmonkey
2 years ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.