WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 6 months ago

#46638 closed defect (bug) (fixed)

unit test for wp_array_slice_assoc()

Reported by: pbearne Owned by: desrosj
Milestone: 5.3 Priority: low
Severity: normal Version: 3.1
Component: General Keywords: has-patch has-unit-tests commit
Focuses: Cc:
PR Number:

Description

just a missing unit test

Attachments (2)

46638.patch (1.9 KB) - added by pbearne 8 months ago.
patch with unit test
46638.diff (2.7 KB) - added by desrosj 6 months ago.

Download all attachments as: .zip

Change History (5)

@pbearne
8 months ago

patch with unit test

#1 @desrosj
8 months ago

  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to Future Release
  • Owner set to desrosj
  • Priority changed from normal to low
  • Status changed from new to reviewing

@desrosj
6 months ago

#2 @desrosj
6 months ago

  • Keywords commit added
  • Milestone changed from Future Release to 5.3
  • Version set to 3.1

Thanks for this, @pbearne!

46638.diff corrects the following:

  • Some alignment to adhere to coding standards.
  • Change the data provider method to have a data_ name.
  • Cleaned up Docblocks to be fully accurate, complete and have proper capitalization.
  • Changed the class name to match the coding standards.
  • Added a few more test scenarios.
  • Added @ticket and @covers tags.
  • Fixed typo in file name.

#3 @desrosj
6 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45371:

General: Add missing unit tests for wp_array_slice_assoc().

Props pbearne, desrosj.
Fixes #46638.

Note: See TracTickets for help on using tickets.