WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#46656 closed defect (bug) (duplicate)

whitespace in exports

Reported by: aristath Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.2
Component: Export Keywords:
Focuses: Cc:
PR Number:

Description

The issue: extra spacing gets added before elements. This causes things like title attributes in menus to break, content build using a page-builder to stop working etc.

This was done is this commit which broke the export functionality for us - or rather it broke content that gets imported on a site if said content has been exported using WP 5.1.1: https://core.trac.wordpress.org/changeset?old_path=%2Ftags%2F5.0.3%2Fsrc%2Fwp-admin%2Fincludes%2Fexport.php&old=45013&new_path=%2Ftags%2F5.1.1%2Fsrc%2Fwp-admin%2Fincludes%2Fexport.php&new=45013&sfp_email=&sfph_mail=#file0

This was probably a coding-standards "fix" so things like this:
<title><?php
were replaced, the opening PHP tag went to the line below and indented. That indentation messes up things.

Change History (3)

#1 @aristath
7 months ago

This is a bug introduced in 5.1.1 and reverting the commit fixes the issue, so that is the simplest and fastest way to handle this. I'm not attaching a patch, if we don't want to revert the commit there are ways to fix it but not as simple or fast.

Last edited 7 months ago by aristath (previous) (diff)

#2 @sgastard
7 months ago

  • Resolution set to duplicate
  • Status changed from new to closed

#3 @desrosj
7 months ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.