WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 3 months ago

#46658 reviewing defect (bug)

Twenty Nineteen: Navigation menu is messy with RTL language

Reported by: manooweb Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots
Focuses: rtl Cc:

Description

Hello,

For our languages switcher, we can add it in primary navigation menu with an options for adding country flag for each language.

With a rtl language like arabic, we have a strange behaviour because of the first li tag does not have the behaviour expected.

See first screenshot attached

Unlike in twenty seventeen

display: inline;

is used instead of

display: inline-block;

When I corrected to

display: inline-block;

it works well again in this case.

See second screenshot attached

Regards

Attachments (3)

messy-menu-wp.jpg (330.5 KB) - added by manooweb 6 months ago.
first screenshot
not-messy-menu-wp.jpg (333.1 KB) - added by manooweb 6 months ago.
second screenshot
correct-menu-rtl-twenty-nineteen.diff (449 bytes) - added by manooweb 6 months ago.
patch file

Download all attachments as: .zip

Change History (6)

@manooweb
6 months ago

first screenshot

@manooweb
6 months ago

second screenshot

#1 @audrasjb
6 months ago

  • Component changed from Themes to Bundled Theme
  • Version trunk deleted

#2 @SergeyBiryukov
6 months ago

  • Summary changed from [twenty nineteen]Navigation menu is messy with rtl language to Twenty Nineteen: Navigation menu is messy with RTL language

#3 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.