WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#4666 closed defect (bug) (fixed)

In WP backend, the 'View site' span needs its own ID

Reported by: JeremyVisser Owned by:
Milestone: 2.3 Priority: normal
Severity: minor Version: 2.3
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

In the code for each page within the WP backend, like so:

<h1>Jeremy Visser <span>(<a href="http://jeremy.sunriseroad.net/">View site &raquo;</a>)</span></h1>

It uses a span to differentiate between the blog title and 'view site' link, in order to make it smaller.

However, the WordPress MU dashboard switcher (ported from WP.com) needs to use additional spans in order to do its JavaScript magic, like so:

<h1><span id="blog-title">Jeremy Visser</span><span id="viewsite">(<a href="http://jeremy.sunriseroad.net/">View site &raquo;</a>)</span></h1>

As you can see, it added the id attribute to both the spans it added. However, the CSS is like this:

#wphead h1 span {
        font-size: .4em;
        letter-spacing: 0;
}

Thus making the blog title and view site link small, which is ugly. So, you need the CSS to look like this (making it only select #viewsite):

#wphead h1 span#viewsite {
        font-size: .4em;
        letter-spacing: 0;
}

...and add an id to the span:

<h1>Jeremy Visser <span id="viewsite">(<a href="http://jeremy.sunriseroad.net/">View site &raquo;</a>)</span></h1>

Voilà.

Attachments (1)

4666.diff (1.2 KB) - added by JeremyVisser 7 years ago.

Download all attachments as: .zip

Change History (4)

JeremyVisser7 years ago

comment:1 JeremyVisser7 years ago

  • Keywords has-patch commit added

comment:2 JeremyVisser7 years ago

Bump — I would really like to get this in, in order to get the dashboard switcher in WordPress MU fixed.

comment:3 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5883]) Add id to viewsite span. Props JeremyVisser. fixes #4666

Note: See TracTickets for help on using tickets.