Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#46663 closed enhancement (fixed)

Site Health: Show/Hide passed tests label and accessibility

Reported by: clorith's profile Clorith Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch site-health
Focuses: Cc:


As mentioned in #46573, the "Show passed tests" button always retained it's string, even when expanded.

Dynamically changing the text wasn't desirable, so this removes the prefix of "Show" altogether, and also improves the attributes used by declaring what ID is being toggled via aria-controls which was previously not included.

Attachments (1)

46663.patch (617 bytes) - added by Clorith 5 years ago.

Download all attachments as: .zip

Change History (3)

5 years ago

#1 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45026:

Site Health: Update "Passed tests" button label to match both expanded and collapsed state.

Add aria-controls to declare what ID is being toggled.

Props Clorith, afercia.
Fixes #46663. See #46573.

#2 @spacedmonkey
5 years ago

  • Component changed from General to Site Health
Note: See TracTickets for help on using tickets.