Opened 4 years ago
Closed 4 years ago
#46669 closed defect (bug) (wontfix)
Twenty Ten: Long non-breaking text strings can cause horizontal scrolling
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch has-screenshots close |
Focuses: | Cc: |
Description (last modified by )
While fixing #36346 I noticed that all Bundled Themes
have some sort of word-wrap
issues when using long non-breaking text strings. While this might be an edge case issue, I believe that it warrants fixing. Also, there doesn't seem to be any backwards compatibility issues.
In order to better track this issue in each theme, I am separating #36346 into separate tickets per theme.
Attachments (5)
Change History (17)
#1
@
4 years ago
- Description modified (diff)
- Keywords has-patch needs-testing added
46669.diff adds
-webkit-hyphens: auto; -moz-hyphens: auto; hyphens: auto; word-wrap: break-word;
to these selectors:
#site-title, #site-description, #content .entry-title, .entry-content, .entry-summary, #comments, #site-info, .navigation
to prevent horizontal scrolling when long non-breaking text strings are used.
However, hyphens: auto;
currently only works in Firefox. Unfortunately nothing worked for me in Chrome, IE11 or Edge.
This patch was tested on a Windows 10 machine, in Firefox, Chrome, IE11 and Edge browsers.
Testing in other OS's and browsers would be appreciated.
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
4 years ago
#6
@
4 years ago
Per input in today's bugscrub, @dswebsme looking to test this on a Mac and update later today.
#7
@
4 years ago
- Keywords needs-testing removed
Patch looks good on Mac.
Tested in Chrome, Safari and Firefox.
Tested Site Title, Site Description, Post Title, Content and Comments with non-breaking strings.
Mac results reflect AFTER screenshots captured by @ianbelanger.
Noting an edge case where pages with long non-breaking titles added to a menu result in horizontal scrolling. This could be addressed in a separate issue as menus can be edited via the UI to solve the issue.
#10
@
4 years ago
I added a comment to #36346 re: the previous tickets closed as wontfix
-- it seemed like it'd be easiest to centralize that discussion in one spot. Any feedback/thoughts would be appreciated there!
#11
@
4 years ago
Thanks for tackling this @ianbelanger! I figured I could check these over while this issue is discussed in #36346 :)
The patch works well, but I noticed some of the indenting includes spaces instead of tabs.
Also, similar to my comment in #46704, what do you think about adding the -ms-
prefix to hyphens as well, for Edge and IE 10-11?
#12
@
4 years ago
- Keywords close added; commit removed
- Milestone 5.2 deleted
- Resolution set to wontfix
- Status changed from assigned to closed
As per the discussion in #36346, I am closing this as a wontfix
See comment for details https://core.trac.wordpress.org/ticket/36346#comment:40
Fixes word-wrap issues