WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#46678 closed defect (bug) (fixed)

Don't echo empty annotation

Reported by: afragen's profile afragen Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: servehappy has-patch dev-feedback
Focuses: Cc:

Description

Don't echo an empty annotation from wp_get_update_php_annotation() and the surrounding tags in wp_update_php_annotation() as it's not appropriate.

Attachments (1)

46678.diff​ (527 bytes) - added by afragen 5 years ago.

Download all attachments as: .zip

Change History (4)

@afragen
5 years ago

#1 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 5.2

#2 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45045:

Plugins: In wp_update_php_annotation(), only display the annotation and the surrounding tags if it's not empty.

Props afragen.
Fixes #46678.

#3 @spacedmonkey
5 years ago

  • Component changed from Plugins to Site Health
Note: See TracTickets for help on using tickets.