Site Health: WP_DEBUG_LOG just shown as Enabled when it actually contains a path

[knutsp]

Under tab Site Info, paragraph WordPress Constants.

Suggestion: When defined, but not identical to true, and not identical to false, display it (the path) as with the other path constants above it.

Related: #46689

[xkon]

Whoops, there is a patch for this at #46692 . I didn't realize there was another ticket for this. Sorry :/ !

[Clorith]

I agree that it's stretching the ternary's a bit deep at this point, let's move the logic down into an if statement or two after the large variable declaration.

[xkon]

46692.2.diff​ replaces the ternary that checks if/else and moves it before the debug info array.

I think that since we already had some vars passed into the array at the very start ( for updates etc ) it made more sense to me this way than adding it into the array later on ( it also cleanly preserves the original placement ).

[Clorith]

Sounds reasonable, before or after makes no difference in this scenario.

[ocean90]

WP_DEBUG_LOG is always defined (false by default) so that check can be simplified a bit.

[xkon]

46692.3.diff​ simplifies the if as @ocean90 mentioned.

I think we can simplify other ternary if/else as well since we check for more constants that are always defined as well. I'll create a new ticket for that :) .

[SergeyBiryukov]

In 45079:

Site Health: If WP_DEBUG_LOG contains a file path, display it on Site Info tab.

Props xkon, knutsp, ocean90.
Fixes #46692.