WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 6 months ago

#46697 closed defect (bug) (wontfix)

Twenty Fifteen: Long non-breaking text strings can cause horizontal scrolling

Reported by: ianbelanger Owned by: ianbelanger
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots close
Focuses: Cc:
PR Number:

Description

While fixing #36346 I noticed that all Bundled Themes have some sort of word-wrap issues when using long non-breaking text strings. While this might be an edge case issue, I believe that it warrants fixing. Also, there doesn't seem to be any backwards compatibility issues.

In order to better track this issue in each theme, I am separating #36346 into separate tickets per theme.

Attachments (9)

46697.diff (1.4 KB) - added by ianbelanger 7 months ago.
Fixes word-wrap issues
46697-twenty-fifteen-site-title-before.PNG (22.7 KB) - added by ianbelanger 7 months ago.
.site-title before in chrome
46697-twenty-fifteen-site-title-after.PNG (30.2 KB) - added by ianbelanger 7 months ago.
.site-title after in chrome
46697-twenty-fifteen-entry-title-before.PNG (21.4 KB) - added by ianbelanger 7 months ago.
.entry-title before in Chrome
46697-twenty-fifteen-entry-title-after.PNG (56.7 KB) - added by ianbelanger 7 months ago.
.entry-title after in Chrome
46697-twenty-fifteen-post-nav-before.PNG (16.9 KB) - added by ianbelanger 7 months ago.
.post navigation before in chrome
46697-twenty-fifteen-post-nav-after.PNG (37.7 KB) - added by ianbelanger 7 months ago.
.post navigation after in chrome
46697-twenty-fifteen-comments-title-before.PNG (19.0 KB) - added by ianbelanger 7 months ago.
.comments-title before in Chrome
46697-twenty-fifteen-comments-title-after.PNG (40.2 KB) - added by ianbelanger 7 months ago.
.comments-title after in Chrome

Download all attachments as: .zip

Change History (20)

@ianbelanger
7 months ago

Fixes word-wrap issues

#1 @ianbelanger
7 months ago

  • Keywords has-patch needs-testing added

46697.diff adds

-webkit-hyphens: auto;
-moz-hyphens: auto;
hyphens: auto;
word-wrap: break-word;

to these selectors:

.site-title,
.site-description,
.entry-title,
.post-navigation .nav-links,
.comments-title

to prevent horizontal scrolling when long non-breaking text strings are used.

However, hyphens: auto; currently only works in Firefox. Unfortunately nothing worked for me in Chrome, IE11 or Edge.

This patch was tested on a Windows 10 machine, in Firefox, Chrome, IE11 and Edge browsers

Testing in other OS's and browsers would be appreciated.

@ianbelanger
7 months ago

.site-title before in chrome

@ianbelanger
7 months ago

.site-title after in chrome

@ianbelanger
7 months ago

.entry-title before in Chrome

@ianbelanger
7 months ago

.entry-title after in Chrome

@ianbelanger
7 months ago

.post navigation before in chrome

@ianbelanger
7 months ago

.post navigation after in chrome

@ianbelanger
7 months ago

.comments-title before in Chrome

@ianbelanger
7 months ago

.comments-title after in Chrome

#2 @ianbelanger
7 months ago

  • Keywords has-screenshots added

#3 @ianbelanger
7 months ago

  • Milestone changed from Future Release to 5.2

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


6 months ago

#5 @JeffPaul
6 months ago

Per input in today's bugscrub, @dswebsme looking to test this on a Mac and update later today.

#6 @dswebsme
6 months ago

  • Keywords needs-testing removed

Patch looks good on Mac.

Tested in Chrome, Safari and Firefox.

Tested Site Title, Site Description, Post Title, Page Title, Content and Comments with non-breaking strings.

Mac results reflect AFTER screenshots captured by @ianbelanger.

#7 @ianbelanger
6 months ago

  • Keywords commit added

Thanks for testing @dswebsme.

I'm marking this for commit

#8 @SergeyBiryukov
6 months ago

Just wanted to note that there are some previous discussions on long non-breaking text strings in bundled themes: #25008, #25232, #29971, all closed as wontfix due to being an edge case. Should we revisit those discussions before making a decision on commit here?

#9 @laurelfulford
6 months ago

I added a comment to #36346 re: the previous tickets closed as wontfix -- it seemed like it'd be easiest to centralize that discussion in one spot. Any feedback/thoughts would be appreciated there!

#10 @laurelfulford
6 months ago

Thanks for tackling this @ianbelanger! I figured I could check these over while this issue is discussed in #36346 :)

46697.diff looks good to me! Similar to my comment in #46704, what do you think about adding the -ms- prefix to hyphens as well, for Edge and IE 10-11? It looks like Twenty Fifteen already uses it in other places it has hyphens set, so it could be good to add for consistency.

#11 @ianbelanger
6 months ago

  • Keywords close added; commit removed
  • Milestone 5.2 deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

As per the discussion in #36346, I am closing this as a wontfix

See comment for details https://core.trac.wordpress.org/ticket/36346#comment:40

Note: See TracTickets for help on using tickets.