WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 8 months ago

Last modified 5 months ago

#46699 closed defect (bug) (fixed)

Site Health: pages should have a unique document title

Reported by: afercia Owned by: afercia
Milestone: 5.2 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: has-screenshots site-health has-patch
Focuses: accessibility Cc:
PR Number:

Description

The new Site Health feature uses two pages that are not exactly real admin "pages".

While there are two physical different files, there's just one admin menu entry: thus, the same name is used for the pages document title.

This actually breaks a few things:

  • usability: when the two pages are open in different browser tabs: the document title is the same so it's not possible to understand which page is open in which tab
  • browsers history: the entries have the same name so exploring the history dropdown doesn't help so much
  • accessibility: the document title is the first thing screen readers announce: it should be unique to allow users to immediately identify the page

http://cldup.com/ByfVJ7y5yu.png

Also, not sure about "page hooks": not my area of expertise but I seem to recall admin pages should have unique names/hooks.

Attachments (3)

46699.diff (625 bytes) - added by chetan200891 8 months ago.
Intitial patch to show unique title for site health pages.
46699.patch (1.2 KB) - added by mukesh27 8 months ago.
Patch.
46699.2.diff (1.0 KB) - added by chetan200891 8 months ago.
Updated patch.

Download all attachments as: .zip

Change History (14)

#1 @afercia
8 months ago

  • Keywords site-health added

@chetan200891
8 months ago

Intitial patch to show unique title for site health pages.

#2 @chetan200891
8 months ago

@afercia I have created initial patch 46699.diff to display unique document title for Site Health pages. Suggestions are welcomed.

Last edited 8 months ago by chetan200891 (previous) (diff)

#3 @chetan200891
8 months ago

  • Keywords has-patch added

#4 @afercia
8 months ago

  • Keywords needs-refresh added

@chetan200891 thanks! Actually, there are two different files for the two pages:
site-health.php
site-health-info.php

I think it should be as simple as setting $title in each page, without conditional statement.

About the wording for the document titles, we can review later. For now I'd propose:

  • Site Health Status
  • Site Health Info

@mukesh27
8 months ago

Patch.

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


8 months ago

#6 @mukesh27
8 months ago

  • Keywords needs-refresh removed

@afercia update patch as per suggested title for both pages with translators

@chetan200891
8 months ago

Updated patch.

#7 @chetan200891
8 months ago

@afercia Thank you for your suggestions. I have updated patch. 46699.2.diff

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


8 months ago

#9 @afercia
8 months ago

  • Owner set to afercia
  • Status changed from new to assigned

not sure about "page hooks": not my area of expertise but I seem to recall admin pages should have unique names/hooks.

Scratch that: "page hooks" are for plugins :)

#10 @afercia
8 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45070:

Accessibility: Make sure the Site Health pages have a unique document title.

The document <title> gives a name to a web document. In the context of the WordPress admin, a unique, meaningful, title is important for various reasons:

  • it allows browser's history to store meaningful entries
  • when multiple browser's tabs are open, it allows users to better identify the tab content
  • it's the first thing screen readers announce when navigating to a web page, thus helping users to identify the nature of the page content

Props chetan200891, mukesh27.
Fixes #46699.

#11 @spacedmonkey
5 months ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.