#46699 closed defect (bug) (fixed)
Site Health: pages should have a unique document title
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.2 | Priority: | normal |
Severity: | normal | Version: | 5.2 |
Component: | Site Health | Keywords: | has-screenshots site-health has-patch |
Focuses: | accessibility | Cc: |
Description
The new Site Health feature uses two pages that are not exactly real admin "pages".
While there are two physical different files, there's just one admin menu entry: thus, the same name is used for the pages document title.
This actually breaks a few things:
- usability: when the two pages are open in different browser tabs: the document title is the same so it's not possible to understand which page is open in which tab
- browsers history: the entries have the same name so exploring the history dropdown doesn't help so much
- accessibility: the document title is the first thing screen readers announce: it should be unique to allow users to immediately identify the page
Also, not sure about "page hooks": not my area of expertise but I seem to recall admin pages should have unique names/hooks.
Attachments (3)
Change History (14)
#2
@
6 years ago
@afercia I have created initial patch 46699.diff to display unique document title for Site Health pages. Suggestions are welcomed.
#4
@
6 years ago
- Keywords needs-refresh added
@chetan200891 thanks! Actually, there are two different files for the two pages:
site-health.php
site-health-info.php
I think it should be as simple as setting $title
in each page, without conditional statement.
About the wording for the document titles, we can review later. For now I'd propose:
- Site Health Status
- Site Health Info
This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.
6 years ago
#6
@
6 years ago
- Keywords needs-refresh removed
@afercia update patch as per suggested title for both pages with translators
#7
@
6 years ago
@afercia Thank you for your suggestions. I have updated patch. 46699.2.diff
Intitial patch to show unique title for site health pages.