Opened 6 years ago
Closed 6 years ago
#46703 closed defect (bug) (fixed)
Twenty Seventeen: Long non-breaking text strings can cause horizontal scrolling
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch has-screenshots commit |
Focuses: | Cc: |
Description
While fixing #36346 I noticed that all Bundled Themes
have some sort of word-wrap
issues when using long non-breaking text strings. While this might be an edge case issue, I believe that it warrants fixing. Also, there doesn't seem to be any backwards compatibility issues.
In order to better track this issue in each theme, I am separating #36346 into separate tickets per theme.
Attachments (4)
Change History (15)
#1
@
6 years ago
- Keywords has-patch needs-testing added
46703.diff adds
-webkit-hyphens: auto; -moz-hyphens: auto; hyphens: auto; word-wrap: break-word; word-break: break-all;
to these selectors:
.site-title
and max-width: 100%;
to body:not(.title-tagline-hidden) .site-branding-text
to prevent horizontal scrolling when long non-breaking text strings are used.
However, hyphens: auto;
currently only works in Firefox. Unfortunately nothing worked for me in Chrome, IE11 or Edge.
This patch was tested on a Windows 10 machine, in Firefox, Chrome, IE11 and Edge browsers
Testing in other OS's and browsers would be appreciated.
#2
@
6 years ago
Turns out all it needed was max-width: 100%;
added to body:not(.title-tagline-hidden) .site-branding-text
to prevent horizontal scrolling when long non-breaking text strings are used.
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
6 years ago
#6
@
6 years ago
Per input in today's bugscrub, @dswebsme looking to test this on a Mac and update later today.
#7
@
6 years ago
- Keywords needs-testing removed
Patch "46703.1.diff" looks good on Mac.
Tested in Chrome, Safari and Firefox.
Tested Site Title, Site Description, Post Title, Page Title, Content and Comments with non-breaking strings.
Mac results reflect AFTER screenshots captured by @ianbelanger.
#8
@
6 years ago
- Keywords commit added
Thanks for testing @dswebsme. 46703.1.diff is an iteration on 46703.diff, so no need to test the first patch.
I'm marking this for commit
Fixes word-wrap issues