WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#46706 closed defect (bug) (fixed)

Ignore Twenty Nineteen's node_modules directory in "jsvalidate:build" task

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Twenty Nineteen uses npm to run various build tasks: node-sass, rtlcss, etc.

Once you run npm install in the theme's directory, grunt build core task fails due to jsvalidate:build attempting to validate files in twentynineteen/node_modules. This directory should be excluded from the task.

Change History (5)

#1 @SergeyBiryukov
5 years ago

  • Description modified (diff)

#2 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45060:

Build/Test Tools: Exclude twentynineteen/node_modules from jsvalidate:build task.

Fixes #46706.

#3 @SergeyBiryukov
5 years ago

  • Component changed from Bundled Theme to Build/Test Tools

#4 @SergeyBiryukov
5 years ago

In 47348:

Built/Test Tools: Ignore the node_modules folder in Twenty Nineteen when running grunt jshint:themes.

Follow-up to [45060], [46352], [46450].

Fixes #49494. See #46706.

#5 @desrosj
4 years ago

#46099 was marked as a duplicate.

Note: See TracTickets for help on using tickets.