Loading from source in WP_Widget_Media_Video

[spacedmonkey]

The video widget allow for src url. However, checks are for attachment that are unnecessary.

[SergeyBiryukov]

if ( $src ) seems to be redundant, given the if ( empty( $src ) ) { return; } check above.

[SergeyBiryukov]

Introduced in [41759], modified in [41765].

[audrasjb]

Remove unnecessary check for $src

[desrosj]

In 47307:

Widgets: Remove unnecessary redundant conditional.

Props spacedmonkey.
Fixes #46718.

[desrosj]

I'm reopening this to revert.

After committing some tests started failing so I dug a bit deeper.

Even though the $attachment check appears redundant, the intention of including it is to ensure the attachment's src is passed through wp_video_shortcode() and the associated filters. The else condition should only be used for videos that are not attachments, and those that do not match the special scenarios (YouTube/Vimeo).

I am going to close this out after reverting, but if this assessment seems incorrect, please let me know!

[desrosj]

In 47308:

Widgets: Revert [47307].

Even though the source URL for an attachment is stored in a variable, attachments should still be passed through the wp_video_shortcode() function.

Unprops desrosj, spacedmonkey.
See #46718.