WordPress.org

Make WordPress Core

Opened 10 months ago

Last modified 3 weeks ago

#46718 accepted defect (bug)

Loading from source in WP_Widget_Media_Video

Reported by: spacedmonkey Owned by: audrasjb
Milestone: 5.4 Priority: normal
Severity: normal Version: 4.8
Component: Widgets Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

The video widget allow for src url. However, checks are for attachment that are unnecessary.

Attachments (2)

46718.diff (760 bytes) - added by spacedmonkey 10 months ago.
46718.1.diff (810 bytes) - added by audrasjb 3 weeks ago.
Remove unnecessary check for $src

Download all attachments as: .zip

Change History (7)

@spacedmonkey
10 months ago

#1 @spacedmonkey
10 months ago

  • Keywords has-patch added

#2 @SergeyBiryukov
10 months ago

if ( $src ) seems to be redundant, given the if ( empty( $src ) ) { return; } check above.

#3 @SergeyBiryukov
10 months ago

Introduced in [41759], modified in [41765].

@audrasjb
3 weeks ago

Remove unnecessary check for $src

#4 @audrasjb
3 weeks ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to audrasjb
  • Status changed from new to accepted

#5 @audrasjb
3 weeks ago

  • Keywords commit added
Note: See TracTickets for help on using tickets.