Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#46728 closed defect (bug) (fixed)

Referring description to "Site Health Status Page" instead of "Site Status Page".

Reported by: chetan200891's profile chetan200891 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: has-patch site-health commit
Focuses: administration Cc:

Description

On Site Health Info page, Description should be referred to Site Health Status Page instead of Site Status Page.

Attachments (2)

46728.diff (1.0 KB) - added by chetan200891 6 years ago.
Created patch.
46728.2.diff (1.1 KB) - added by chetan200891 6 years ago.
Updated patch.

Download all attachments as: .zip

Change History (12)

@chetan200891
6 years ago

Created patch.

#1 @chetan200891
6 years ago

  • Keywords has-patch added

#2 @afercia
6 years ago

Yep, however I'm not sure why the h2 heading in the site status page is:
Site Health Status

while on the site info page is just:
Site Info

I'd tend to think they should be consistent, and the description should be based on the h2.
/Cc @Clorith any preference? :)

#3 @Clorith
6 years ago

Sounds like it might be an artifact from the plugin before the new UI landed, lots of changes there that may have been missed still.

I agree they should be consistent, personally I prefer the look of the more descriptive Site Health Status, as single word headings have never felt right to me, but that may be a language thing.

@chetan200891
6 years ago

Updated patch.

#4 @chetan200891
6 years ago

@afercia Based on #46699 We should use consistent titles of pages. So I have updated patch. Thank you for your suggestion!

#5 @chetan200891
6 years ago

Also it will be good if someone can add site-health keyword. So this ticket can be in loop. :)

#6 @Clorith
6 years ago

  • Keywords site-health added

#7 @Clorith
6 years ago

  • Keywords commit added

46728.2.diff looks good and is a quick win, let's go with that.

#8 @Clorith
6 years ago

  • Milestone changed from Awaiting Review to 5.2

#9 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45120:

Site Health: Use a consistent heading and description when referring to Info and Status pages.

Props chetan200891, afercia.
Fixes #46728.

#10 @spacedmonkey
6 years ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.