WordPress.org

Make WordPress Core

Changes between Version 4 and Version 21 of Ticket #46750


Ignore:
Timestamp:
07/07/2019 08:04:50 PM (3 months ago)
Author:
laurelfulford
Comment:

Thanks @kjellr! The patch is looking good! Following up on few comments from above:

In the editor, the full-width image blocks bleed out of the group for me

I think this is actually just related to this Gutenberg issue... Should be all set as of Gutenberg v6.0 — would you mind giving those another test?

Yes, looking good now!

In the editor, full-width columns are slightly indented in the standard and wide-width groups (but display as expected in full-width groups)

Yeah, I think this is a core Gutenberg bug, as it's showing up all themes I've tried. I've filed a bug for it here... In the meantime, I don't think we should make any adjustments for it here.

Thanks for digging into that! I agree that it makes sense not to address that in the themes if it's happening in all.

And this might be getting into the weeds, but Twenty Nineteen has styles that switch text to white when you set a darker background colour...

If it makes sense to you, I'd prefer to get this patch in as is, and then address those separately. I anticipate a lot of trial and error there.

That makes sense to me! I hate issues like this, too, they're a pain to fix -- I agree it'll be easier to dig into/test separately.

All my concerns have been addressed, so I'll work on getting this committed.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #46750

    • Property Keywords needs-testing removed
  • Ticket #46750 – Description

    v4 v21  
    55
    66This block acts as a container for other blocks. The Group block supports standard, wide and full alignments for both itself and its child blocks. The original wide + full styles for Twenty Nineteen only work properly for direct children of `entry-content`, so the theme requires a patch to ensure proper compatibility with this new block.
     7
     8> If it makes sense to you, I'd prefer to get this patch in as is, and then address those separately. I anticipate a lot of trial and error there
    79
    810**The Group block is currently assigned to the Gutenberg 5.5 milestone. This patch (or a similar one) should be merged into Twenty Nineteen alongside that release, to ensure that the Group block works as intended upon release.**