WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 4 of Ticket #46750


Ignore:
Timestamp:
04/12/2019 05:36:49 PM (7 years ago)
Author:
kjellr
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #46750

    • Property Summary changed from Twenty Nineteen: Add styles to support the section block to Twenty Nineteen: Add styles to support the group block

  • Ticket #46750 – Description

    initial v4  
    1 Gutenberg has recently merged in a new "Section" block:
     1Gutenberg has recently merged in a new "Group" block:
    22
    33https://github.com/WordPress/gutenberg/pull/13964
     4(Renamed "Group" here: https://github.com/WordPress/gutenberg/pull/14920)
    45
    5 This block acts as a container for other blocks. The Section block supports standard, wide and full alignments for both itself and its child blocks. The original wide + full styles for Twenty Nineteen only work properly for direct children of `entry-content`, so the theme requires a patch to ensure proper compatibility with this new block.
     6This block acts as a container for other blocks. The Group block supports standard, wide and full alignments for both itself and its child blocks. The original wide + full styles for Twenty Nineteen only work properly for direct children of `entry-content`, so the theme requires a patch to ensure proper compatibility with this new block.
    67
    7 **The Section block is currently assigned to the Gutenberg 5.5 milestone. This patch (or a similar one) should be merged into Twenty Nineteen alongside that release, to ensure that the Section block works as intended upon release.**
     8**The Group block is currently assigned to the Gutenberg 5.5 milestone. This patch (or a similar one) should be merged into Twenty Nineteen alongside that release, to ensure that the Group block works as intended upon release.**
    89
    9 The attach patch includes styles for the Section block, in both the front end and the editor. In general, standard, wide and full-aligned blocks inside of Section blocks should appear consistent with the way they appear outside of Section blocks. Since Section blocks themselves can in turn be standard, wide, or full-aligned, the behavior of child elements should roughly correspond to the recommendation laid out here:
     10The attach patch includes styles for the Group block, in both the front end and the editor. In general, standard, wide and full-aligned blocks inside of Group blocks should appear consistent with the way they appear outside of Group blocks. Since Group blocks themselves can in turn be standard, wide, or full-aligned, the behavior of child elements should roughly correspond to the recommendation laid out here:
    1011
    1112https://github.com/WordPress/gutenberg/pull/13964#issuecomment-472562800
    … …  
    21221. Until there's a build for Gutenberg 5.5, the best way to test this is to compile the `master` branch of Gutenberg and run it on your core dev environment.
    2223
    23 2. Add a new post, and switch to the code view. In that view, paste in this sample content to test a wide variety of Section block alignments, alongside various child blocks: https://cloudup.com/czLTdIYcU5O
     242. Add a new post, and switch to the code view. In that view, paste in this sample content to test a wide variety of Group block alignments, alongside various child blocks: https://cloudup.com/cYDmpgD08FU
    2425
    25263. Verify that all appears as expected, and that there is no horizontal scroll added to the page. Be sure to test across a wide range of breakpoints as well!