WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#46755 closed defect (bug) (fixed)

Site Health: Missing i18n

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-screenshots needs-patch good-first-bug
Focuses: Cc:

Description

Site Health Status page has Security and Performance badges on list items, see the screenshot for reference.

The labels for these badges are missing __() calls.

Attachments (2)

46755.png​ (13.5 KB) - added by SergeyBiryukov 6 years ago.
46755.patch​ (4.3 KB) - added by iworks 6 years ago.
Add i18n functions.

Download all attachments as: .zip

Change History (5)

@SergeyBiryukov
6 years ago

#1 follow-up: @afercia
6 years ago

@SergeyBiryukov I think this is covered in #46683 (which still needs a patch though). See https://core.trac.wordpress.org/ticket/46683#comment:2

#2 in reply to: ↑ 1 @SergeyBiryukov
6 years ago

Replying to afercia:

@SergeyBiryukov I think this is covered in #46683 (which still needs a patch though).

Thanks for the link! Yes, that comment does cover this. However it also covers a lot of other items, and I think there's still some benefit in handling this self-contained change as a good-first-bug :)

@iworks
6 years ago

Add i18n functions.

#3 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45095:

Site Health: Add missing i18n for Security and Performance badge labels.

Props iworks.
Fixes #46755. See #46683.

Note: See TracTickets for help on using tickets.