WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 6 months ago

Last modified 4 months ago

#46760 closed defect (bug) (fixed)

Site Health: CSS line-height values should be unitless

Reported by: mukesh27 Owned by: ianbelanger
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch good-first-bug needs-testing site-health
Focuses: ui, administration, coding-standards Cc:
PR Number:

Description (last modified by SergeyBiryukov)

As outlined in #44643, CSS line-height values should be unit less unless necessary to be defined as a specific pixel value.

This ticket covers wp-admin/css/site-health.css

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.

Attachments (1)

46760.diff (667 bytes) - added by mukesh27 7 months ago.
Patch.

Download all attachments as: .zip

Change History (7)

@mukesh27
7 months ago

Patch.

#1 @ianbelanger
7 months ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 5.2
  • Owner set to ianbelanger
  • Status changed from new to assigned
  • Version trunk deleted

Thanks @mukesh27, the patch looks good on Windows 10, as mentioned above, it still needs testing on other OS's

#2 @mukesh27
7 months ago

I tested 46760.diff patch in Ubuntu 18.04.2 LTS with Google Chrome Version 73.0.3683.75 and Firefox Version 65.0.1

#3 @afercia
7 months ago

  • Keywords site-health added

#4 @SergeyBiryukov
6 months ago

  • Description modified (diff)

#5 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45128:

CSS Coding Standards: Use unitless values for line-height in wp-admin/css/site-health.css.

Props mukesh27, ianbelanger, pbiron, afercia.
Fixes #46760. See #44643.

#6 @spacedmonkey
4 months ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.