![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 7 years ago
Closed 7 years ago
#46770 closed defect (bug) (fixed)
Twenty Eleven: Background gradient argument
| Reported by: | Malae | Owned by: | desrosj |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.2 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
Line 1587
.featured-post .feature-text:after, .featured-post .feature-image.small:after
Value Error : background The first argument to the linear-gradient function should be to top, not top )
Attachments (4)
Change History (14)
#1
@
7 years ago
- Component Themes → Bundled Theme
- Summary Twentyeleven theme style.css → Twenty Eleven: Background gradient argument
#3
@
7 years ago
- Keywords has-patch added; needs-patch removed
- Milestone Awaiting Review → Future Release
- Severity minor → normal
#5
@
7 years ago
Thanks for your patch @man4toman,
In order to better track issues in each theme, could you please remove the Twenty Twelve fix from your patch and create a new ticket just for that theme. Thanks
#6
@
7 years ago
Hi @ianbelanger
The new patch attached, I'll create a new ticket for "Twenty Twelve".
#7
@
7 years ago
- Keywords commit added
- Milestone Future Release → 5.2
- Version 4.9.8
Thanks @man4toman,
The patch looks good, I am marking this for commit
#8
@
7 years ago
As pointed out by @joyously in #46786
The patch doesn't actually fix the problem, because this ticket was just written for syntax. The real problem is that the old syntax goes the other direction from the new syntax.
For example,
-webkit-linear-gradient(top, #f4f4f4, #e6e6e6);
will start at top with #f4f4f4 and go down to #e6e6e6. But
linear-gradient(to top, #f4f4f4, #e6e6e6);
will start at bottom with #f4f4f4 and go to top to #e6e6e6.
So in 46770.4.diff I have switched linear-gradient to use to bottom to correct the issue.
#46773 was marked as a duplicate.