WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#46770 closed defect (bug) (fixed)

Twenty Eleven: Background gradient argument

Reported by: Malae Owned by: desrosj
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Line 1587
.featured-post .feature-text:after, .featured-post .feature-image.small:after

Value Error : background The first argument to the linear-gradient function should be to top, not top )

Attachments (4)

46770.diff (858 bytes) - added by ianbelanger 5 months ago.
Fixes linear-gradient argument
46770-2.patch (7.2 KB) - added by man4toman 5 months ago.
46770-3.patch (1.6 KB) - added by man4toman 5 months ago.
46770.4.diff (1.6 KB) - added by ianbelanger 5 months ago.
Changes gradient direction in linear-gradient

Download all attachments as: .zip

Change History (14)

#1 @SergeyBiryukov
5 months ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Twentyeleven theme style.css to Twenty Eleven: Background gradient argument

#2 @SergeyBiryukov
5 months ago

#46773 was marked as a duplicate.

@ianbelanger
5 months ago

Fixes linear-gradient argument

#3 @ianbelanger
5 months ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to Future Release
  • Severity changed from minor to normal

@man4toman
5 months ago

#4 @man4toman
5 months ago

Twenty Twelve needs updates too.
And the new patch attached for other css files.

#5 @ianbelanger
5 months ago

Thanks for your patch @man4toman,

In order to better track issues in each theme, could you please remove the Twenty Twelve fix from your patch and create a new ticket just for that theme. Thanks

@man4toman
5 months ago

#6 @man4toman
5 months ago

Hi @ianbelanger
The new patch attached, I'll create a new ticket for "Twenty Twelve".

#7 @ianbelanger
5 months ago

  • Keywords commit added
  • Milestone changed from Future Release to 5.2
  • Version 4.9.8 deleted

Thanks @man4toman,

The patch looks good, I am marking this for commit

@ianbelanger
5 months ago

Changes gradient direction in linear-gradient

#8 @ianbelanger
5 months ago

As pointed out by @joyously in #46786

The patch doesn't actually fix the problem, because this ticket was just written for syntax. The real problem is that the old syntax goes the other direction from the new syntax.
For example,
-webkit-linear-gradient(top, #f4f4f4, #e6e6e6);
will start at top with #f4f4f4 and go down to #e6e6e6. But
linear-gradient(to top, #f4f4f4, #e6e6e6);
will start at bottom with #f4f4f4 and go to top to #e6e6e6.

So in 46770.4.diff I have switched linear-gradient to use to bottom to correct the issue.

#9 @desrosj
5 months ago

  • Owner set to desrosj
  • Status changed from assigned to reviewing

#10 @desrosj
5 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45109:

Twenty Eleven: Correct linear-gradient direction argument syntax.

In CSS, the linear-gradient function requires that the direction value explicitly use to instead of an implicit from.

Props: ianbelanger, Malae, man4toman.
Fixes #46770.

Note: See TracTickets for help on using tickets.