Make WordPress Core

Opened 5 years ago

Last modified 3 weeks ago

#46771 new defect (bug)

Twenty Eleven: Negative values for padding

Reported by: malae's profile Malae Owned by:
Milestone: Awaiting Review Priority: normal
Severity: minor Version: 4.9.8
Component: Bundled Theme Keywords: has-patch 2nd-opinion
Focuses: css Cc:


Line 2799
#ie7 article.intro Value Error : padding-left -7.6% negative values are not allowed : -7.6%

Line 2800
#ie7 article.intro Value Error : padding-right -7.6% negative values are not allowed : -7.6%

Attachments (3)

46771.diff (475 bytes) - added by mukesh27 5 years ago.
Patch that remove left and right padding in IE
46771.1.diff (484 bytes) - added by sabernhardt 3 years ago.
positive padding of 7.6%
46771.2.diff (439 bytes) - added by sabernhardt 2 years ago.
remove the two faulty lines

Download all attachments as: .zip

Change History (9)

5 years ago

Patch that remove left and right padding in IE

#1 @mukesh27
5 years ago

  • Keywords has-patch added; needs-patch removed

#2 @SergeyBiryukov
5 years ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Twentyeleven theme style.css to Twenty Eleven: Negative values for padding

#3 @sabernhardt
3 years ago

  • Focuses css added
  • Keywords 2nd-opinion added

Thanks for the report and patch!

Because older Internet Explorer versions are hardly used and no longer officially supported, this would be a candidate for closing as won't fix. However, I think the theme's authors intended to have positive padding of 7.6% on the left and right sides.

Other possibilities:

  1. Remove the lines that set padding for IE7 (so it falls back to 8.9%)
  2. Remove all IE7 styles

3 years ago

positive padding of 7.6%

2 years ago

remove the two faulty lines

#4 @sabernhardt
2 years ago

Correcting the values this late seems quite absurd. So I uploaded another patch for removing those lines.

If we want to remove more, that would belong in another ticket (to address older IE conditional CSS in Twenty Ten to Twenty Seventeen).

#5 @sabernhardt
10 months ago

This may be removed as part of #56699.

#6 @poena
3 weeks ago

This has not been removed, shall we move forward with patch 46771.2.diff?

Note: See TracTickets for help on using tickets.