Twenty Eleven: Negative values for padding

[Malae]

Line 2799
#ie7 article.intro Value Error : padding-left -7.6% negative values are not allowed : -7.6%

Line 2800
#ie7 article.intro Value Error : padding-right -7.6% negative values are not allowed : -7.6%

[mukesh27]

Patch that remove left and right padding in IE

[sabernhardt]

Thanks for the report and patch!

Because older Internet Explorer versions are hardly used and no longer officially supported, this would be a candidate for closing as won't fix. However, I think the theme's authors intended to have positive padding of 7.6% on the left and right sides.

Other possibilities:

1. Remove the lines that set padding for IE7 (so it falls back to 8.9%)
2. Remove all IE7 styles

[sabernhardt]

positive padding of 7.6%

[sabernhardt]

remove the two faulty lines

[sabernhardt]

Correcting the values this late seems quite absurd. So I uploaded another patch for removing those lines.

If we want to remove more, that would belong in another ticket (to address older IE conditional CSS in Twenty Ten to Twenty Seventeen).

[sabernhardt]

This may be removed as part of #56699.

[poena]

This has not been removed, shall we move forward with patch 46771.2.diff?

[karmatosed]

I would agree with everyone that removing those lines makes sense. I am therefore going to agree that going ahead with the diff to do so makes sense. I will add the commit keyword to take it through.

[karmatosed]

I'm going to go back on my own decision here, apologies. I read through https://core.trac.wordpress.org/ticket/56699. It feels to me like if there has been work done to remove IE specific lines entirely, that removing this all would be the better move over just the negative pieces.

I am going to include @desrosj in this conversation as the originator of the ticket and work on IE specific. On reflection I do think that committing IE 7 changes, even going back over a past bug feels not the best when we perhaps could just remove them. I am happy to be wrong but it did make me pause myself on committing this, apologies there.

[sabernhardt]

See also #58836

[karmatosed]

Thank you everyone, this came up in the scrub today and was decided to commit.

[karmatosed]

In 58005:

Twenty Eleven: Removes Negative values for padding.

This fixes the issue where negative values aren't allows in older versions of IE. There is more discussion in another ticket on a wider approach, but for now the decision to commit this was made as an interim solution.

Props mukesh27, SergeyBiryukov, sabernhardt, poena.
Fixes #46771.