Opened 6 years ago
Closed 13 months ago
#46771 closed defect (bug) (fixed)
Twenty Eleven: Negative values for padding
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.6 | Priority: | normal |
Severity: | minor | Version: | 4.9.8 |
Component: | Bundled Theme | Keywords: | has-patch 2nd-opinion commit |
Focuses: | css | Cc: |
Description
Line 2799
#ie7 article.intro Value Error : padding-left -7.6% negative values are not allowed : -7.6%
Line 2800
#ie7 article.intro Value Error : padding-right -7.6% negative values are not allowed : -7.6%
Attachments (3)
Change History (15)
#2
@
6 years ago
- Component changed from Themes to Bundled Theme
- Summary changed from Twentyeleven theme style.css to Twenty Eleven: Negative values for padding
#3
@
4 years ago
- Focuses css added
- Keywords 2nd-opinion added
Thanks for the report and patch!
Because older Internet Explorer versions are hardly used and no longer officially supported, this would be a candidate for closing as won't fix
. However, I think the theme's authors intended to have positive padding of 7.6% on the left and right sides.
Other possibilities:
- Remove the lines that set padding for IE7 (so it falls back to 8.9%)
- Remove all IE7 styles
#4
@
4 years ago
Correcting the values this late seems quite absurd. So I uploaded another patch for removing those lines.
If we want to remove more, that would belong in another ticket (to address older IE conditional CSS in Twenty Ten to Twenty Seventeen).
#7
@
14 months ago
- Keywords commit added
I would agree with everyone that removing those lines makes sense. I am therefore going to agree that going ahead with the diff to do so makes sense. I will add the commit keyword to take it through.
#8
@
14 months ago
- Keywords commit removed
I'm going to go back on my own decision here, apologies. I read through https://core.trac.wordpress.org/ticket/56699. It feels to me like if there has been work done to remove IE specific lines entirely, that removing this all would be the better move over just the negative pieces.
I am going to include @desrosj in this conversation as the originator of the ticket and work on IE specific. On reflection I do think that committing IE 7 changes, even going back over a past bug feels not the best when we perhaps could just remove them. I am happy to be wrong but it did make me pause myself on committing this, apologies there.
Patch that remove left and right padding in IE