WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#46774 closed defect (bug) (fixed)

Unitless CSS value reintroduced in Dashicons

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 5.2 Priority: normal
Severity: minor Version: 5.2
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

In [45040], the Dashicons font was updated for 5.2. However, it reverted a small CSS fix that was made in [42689]. <time> values in CSS should not be unitless.

I opened a ​PR on the Dashicons repository to prevent this from happening again in the future.

Attachments (1)

46774.diff​ (387 bytes) - added by desrosj 6 years ago.

Download all attachments as: .zip

Change History (2)

@desrosj
6 years ago

#1 @desrosj
6 years ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 45097:

Administration: Remove unnecessary transition-delay values from Dashicons.

A unitless 0 value for a <time> CSS data type was reintroduced in [45040]. This is allowed for <length> data types, but is invalid for <time>.

See #43195.
Fixes #46774.

Note: See TracTickets for help on using tickets.