#46776 closed defect (bug) (duplicate)
Add missing translator comments and update about-text function usage in wp-admin/about.php
Reported by: | thrijith | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 5.1 |
Component: | Help/About | Keywords: | |
Focuses: | Cc: |
Description
Add missing translator comments in wp-admin/about.php
Correct the usage of
<p class="about-text"><?php printf( __( 'Thank you for updating to the latest version!' ), $display_version ); ?></p>
Attachments (1)
Change History (10)
#2
follow-up:
↓ 4
@
5 years ago
Hi @mukesh27, thanks for pointing this out. Should I add this patch in #46408?
#5
@
5 years ago
- Milestone changed from Awaiting Review to 5.3
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
- Version changed from trunk to 5.1
This ticket was mentioned in Slack in #core by david.baumwald. View the logs.
5 years ago
#7
@
5 years ago
- Keywords close added
It looks like this was all resolved in #46408 and its accompanying commits. Marking this for closure.
#8
@
5 years ago
- Keywords has-patch close removed
- Milestone 5.3 deleted
- Resolution set to fixed
- Status changed from reviewing to closed
Thanks for everyone's work on this ticket, I'm closing this as the verbiage has changed and the current trunk has both the proper use of the placeholder along with a translator comment as can be seen here;
<p class="about-text"> <?php printf( /* translators: %s: The current WordPress version number. */ __( 'Congratulations on updating to WordPress %s! This update makes it easier than ever to fix your site if something goes wrong.' ), $display_version ); ?> </p>
https://github.com/WordPress/wordpress-develop/blob/master/src/wp-admin/about.php#L30-L38
The text was changed for 5.2 in commit Changeset#45271, and the placeholder and translator comment introduced in commit Changeset#45338.
Related #46408