Site Health: PHP upgrade recommendation label should not be "security" when on a secure version

[earnjam]

I have a site running on PHP 7.2.16, which is a supported and actively maintained version. It does not have any currently know security issues.

On the Site Health screen, I get the recommendation to update my PHP version with a label of Security. See attached screenshot.

I think this label should be changed to Performance in the instance where a user is using a secure and actively supported version of PHP. It's misleading to say a user needs to update for security reasons in that case.

The serve happy API, which is used for this test, returns is_supported and is_secure values. We should look at those to determine whether to show Security or Performance as the label.

[Clorith]

This is a good call, we should also do the same for core.

For MySQL, I'm thinking it should be performance in general, then security if it's outdated.

I've supplied 46789.patch​ which swaps all three around for clarity sake.

[SergeyBiryukov]

In 45121:

Site Health: Update recommendation labels to highlight Performance instead of Security when using a supported and actively maintained version of WordPress, PHP, or MySQL.

Props Clorith, earnjam.
Fixes #46789.