Make WordPress Core

Opened 19 months ago

Closed 19 months ago

Last modified 16 months ago

#46789 closed defect (bug) (fixed)

Site Health: PHP upgrade recommendation label should not be "security" when on a secure version

Reported by: earnjam Owned by: SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: site-health has-screenshots has-patch commit
Focuses: ui, administration Cc:


I have a site running on PHP 7.2.16, which is a supported and actively maintained version. It does not have any currently know security issues.

On the Site Health screen, I get the recommendation to update my PHP version with a label of Security. See attached screenshot.

I think this label should be changed to Performance in the instance where a user is using a secure and actively supported version of PHP. It's misleading to say a user needs to update for security reasons in that case.

The serve happy API, which is used for this test, returns is_supported and is_secure values. We should look at those to determine whether to show Security or Performance as the label.

Attachments (3)

Screen Shot 2019-04-03 at 4.35.18 PM.png (80.0 KB) - added by earnjam 19 months ago.
Screen Shot 2019-04-03 at 4.35.38 PM.png (60.6 KB) - added by earnjam 19 months ago.
46789.patch (2.2 KB) - added by Clorith 19 months ago.

Download all attachments as: .zip

Change History (8)

#1 @ianbelanger
19 months ago

  • Keywords has-screenshots added

#2 @xkon
19 months ago

  • Component changed from General to Administration
  • Focuses ui administration added
  • Keywords site-health added
  • Version set to trunk

19 months ago

#3 @Clorith
19 months ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 5.2

This is a good call, we should also do the same for core.

For MySQL, I'm thinking it should be performance in general, then security if it's outdated.

I've supplied 46789.patch which swaps all three around for clarity sake.

#4 @SergeyBiryukov
19 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45121:

Site Health: Update recommendation labels to highlight Performance instead of Security when using a supported and actively maintained version of WordPress, PHP, or MySQL.

Props Clorith, earnjam.
Fixes #46789.

#5 @spacedmonkey
16 months ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.