WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #46798, comment 2


Ignore:
Timestamp:
05/28/2019 11:21:31 PM (6 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #46798, comment 2

    initial v1  
    1 Wondering how to best fix the above line endings problems. Can probably ass a basic normalization as in 46798.diff, but seems a bit... fragile?
     1Wondering how to best fix the above line endings problems. Can probably add a basic normalization as in 46798.diff, but seems a bit... fragile?
    22
    33The other option is to do `assertContains()` as in all other HTML output testing. All errors are in `phpunit/tests/dependencies/scripts.php` and are caused by comparing with `wp_scripts_print_translations_output`. It tests translation scripts outputted with `printf()`. Seems we can test just one line there, not the whole script.