Context Navigation

← Previous Ticket
Next Ticket →

#46807 closed defect (bug) (fixed)

Twenty Sixteen: font-style error in blocks.css

Reported by:	Malae	Owned by:	johnjamesjacoby
Priority:	normal	Milestone:	5.9
Component:	Bundled Theme	Version:	5.0
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:	css

Description

Twentysixteen theme
blocks.css line 81 .wp-block-pullquote cite
Value Error : font-style none is not a font-style value : none

Attachments (2)

46807.diff (460 bytes ) - added by mukesh27 7 years ago.: Patch.
46807.1.diff (439 bytes ) - added by sabernhardt 5 years ago.

Download all attachments as: .zip

Change History (9)

#1 @mukesh27
7 years ago

Component Themes → Bundled Theme
Summary Twenty sixteen theme 81 blocks.css value error → Twenty sixteen: 81 value error in blocks.css

@mukesh27
7 years ago

Attachment 46807.diff added

Patch.

#2 @mukesh27
7 years ago

Keywords has-patch added; needs-patch removed
Summary Twenty sixteen: 81 value error in blocks.css → Twenty sixteen: font-style error in blocks.css

@Malae replicated same issue in W3C CSS Validation. Above patch fix the issue.

Last edited 7 years ago by mukesh27 (previous) (diff)

#3 @nielslange
7 years ago

Summary Twenty sixteen: font-style error in blocks.css → Twenty Sixteen: font-style error in blocks.css

@sabernhardt
5 years ago

Attachment 46807.1.diff added

#4 @sabernhardt
5 years ago

Focuses css added
Keywords commit added
Milestone Awaiting Review → 5.9

I simply recreated the patch from the root directory.

The pullquote citation font-style is normal in wp-block-library-theme-inline-css, but we can correct it in the blocks.css file.

#5 @mukesh27
5 years ago

@sabernhardt Thanks for refreshing the patch.

#6 @sabernhardt
5 years ago

Version 5.1 → 5.0

#7 @johnjamesjacoby
5 years ago

Owner set to johnjamesjacoby
Resolution → fixed
Status new → closed

In 52004:

Themes/TwentySixteen: correct invalid CSS font-style value.

This change swaps out none for normal in the .wp-block-pullquote cite styling of blocks.css.

Props malae, mukesh27, sabernhardt.

Fixes #46807.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#46807 closed defect (bug) (fixed)

Twenty Sixteen: font-style error in blocks.css

Description

Attachments (2)

Change History (9)

#1 @mukesh27 7 years ago

@mukesh27 7 years ago

#2 @mukesh27 7 years ago

#3 @nielslange 7 years ago

@sabernhardt 5 years ago

#4 @sabernhardt 5 years ago

#5 @mukesh27 5 years ago

#6 @sabernhardt 5 years ago

#7 @johnjamesjacoby 5 years ago