Make WordPress Core

Opened 5 years ago

Closed 2 years ago

#46807 closed defect (bug) (fixed)

Twenty Sixteen: font-style error in blocks.css

Reported by: malae's profile Malae Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description

Twentysixteen theme
blocks.css line 81 .wp-block-pullquote cite
Value Error : font-style none is not a font-style value : none

Attachments (2)

46807.diff (460 bytes) - added by mukesh27 5 years ago.
Patch.
46807.1.diff (439 bytes) - added by sabernhardt 2 years ago.

Download all attachments as: .zip

Change History (9)

#1 @mukesh27
5 years ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Twenty sixteen theme 81 blocks.css value error to Twenty sixteen: 81 value error in blocks.css

@mukesh27
5 years ago

Patch.

#2 @mukesh27
5 years ago

  • Keywords has-patch added; needs-patch removed
  • Summary changed from Twenty sixteen: 81 value error in blocks.css to Twenty sixteen: font-style error in blocks.css

@Malae replicated same issue in W3C CSS Validation. Above patch fix the issue.

Last edited 5 years ago by mukesh27 (previous) (diff)

#3 @nielslange
4 years ago

  • Summary changed from Twenty sixteen: font-style error in blocks.css to Twenty Sixteen: font-style error in blocks.css

@sabernhardt
2 years ago

#4 @sabernhardt
2 years ago

  • Focuses css added
  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.9

I simply recreated the patch from the root directory.

The pullquote citation font-style is normal in wp-block-library-theme-inline-css, but we can correct it in the blocks.css file.

#5 @mukesh27
2 years ago

@sabernhardt Thanks for refreshing the patch.

#6 @sabernhardt
2 years ago

  • Version changed from 5.1 to 5.0

#7 @johnjamesjacoby
2 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 52004:

Themes/TwentySixteen: correct invalid CSS font-style value.

This change swaps out none for normal in the .wp-block-pullquote cite styling of blocks.css.

Props malae, mukesh27, sabernhardt.

Fixes #46807.

Note: See TracTickets for help on using tickets.