Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#46809 closed defect (bug) (fixed)

Site Health: Copy to clipboard is missing the code back-ticks

Reported by: Clorith Owned by: SergeyBiryukov
Priority: normal Milestone: 5.2
Component: Site Health Version: 5.2
Severity: normal Keywords: site-health has-patch commit
Cc: Focuses:

Description

After the update to the copy to clipboard functionality, a regression occurred and the code back-ticks (`) no longer gets included around the status.

This should be re-implemented, to ensure pasting formats the data accordingly whenever possible.

Attachments (1)

46809.patch​ (711 bytes ) - added by Clorith 8 years ago.

Download all attachments as: .zip

Change History (5)

@Clorith
8 years ago

#1 @Clorith
8 years ago

  • Keywords has-patch commit added; needs-patch removed

46809.patch​ adds the back-tick to the WP_Debug_Data::format() function, which is specifically made to format output for direct pasting to a support location.

#2 @SergeyBiryukov
8 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 45119:

Site Health: Restore backticks in "Copy to clipboard" functionality, accidentally removed in [45044].

The backticks ensure that the data is formatted accordingly on pasting whenever possible.

Props Clorith.
Fixes #46809.

#3 @SergeyBiryukov
8 years ago

In 45122:

PHPCS: Fix WPCS violation in [45119].

See #46809.

#4 @spacedmonkey
7 years ago

  • Component Administration → Site Health
Note: See TracTickets for help on using tickets.