Site Health reports "A plugin has prevented updates" when no plugins are activated.

[axaak]

*Steps to re-create*

Version: WordPress 5.2-beta1-45112
Deactivate all plugins
Run site check get message

A plugin has prevented updates by disabling wp_version_check().

but no plugins are activated. The site cannot be updated but not because of plugins. Better wording might be "Automatic updates are disabled"

[axaak]

A plugin has prevented message

[knutsp]

Duplicate of #46616.

Hello @axaak

Welcome back and thanks for the report.

It seems, however, this has already been fixed.

[Clorith]

This appears to be a result of the test site running on https without a valid certificate.

We do a call back to the page to test for the wp_version_check filter, and the wp_remote_get call will fail with an invalid certificate, causing it to show an error state.

Sounds like it would be more valid to show a warning state if we can't load the result page.

[Clorith]

46814.patch​ applies a check for errors in the request, and marks it accordingly if it's a test failure, or an incomplete test.

This means if the only thing we can't do is test for this filter, due to a broken certificate or similar, it will get a recommended status with an appropriate associated text.

[SergeyBiryukov]

In 45118:

Site Health: Display a correct error message for a failing request in wp_version_check() test.

Props Clorith, axaak.
Fixes #46814.