WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#46821 closed enhancement (fixed)

Twenty Nineteen: Fix inconsistent tab/space indentation in some scss

Reported by: iamdmitrymayorov Owned by: SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots
Focuses: Cc:

Description

There are two lines in _blocks.scss in Twenty Nineteen theme that have indentation issues. The first one has redundant tabs and the second one has mixed tab/space indentation.

It looks like the second line was copied from another document with different indentation style.

Not a huge deal, but probably still worth fixing.

Attachments (2)

46821.diff (603 bytes) - added by iamdmitrymayorov 2 years ago.
46821.patch (11.7 KB) - added by mukesh27 2 years ago.
Added patch that fix inconsistent tab/space indentation in remaining scss files.

Download all attachments as: .zip

Change History (6)

#1 @iamdmitrymayorov
2 years ago

It might not be very clear from the patch preview, so here's a screenshot as well: https://monosnap.com/file/RSq3zrNh42uFQJzxm0RCDgQFWynQqV

#2 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 5.2
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @mukesh27
2 years ago

  • Keywords has-patch has-screenshots added
  • Summary changed from Twenty Nineteen: Fix inconsistent tab/space indentation in _blocks.scss to Twenty Nineteen: Fix inconsistent tab/space indentation in some scss

Updated title as some files are also contain inconsistent tab/space indentation so that also needs to fix.

@mukesh27
2 years ago

Added patch that fix inconsistent tab/space indentation in remaining scss files.

#4 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45132:

Twenty Nineteen: Fix inconsistent tab/space indentation in style files.

Props iamdmitrymayorov, mukesh27.
Fixes #46821.

Note: See TracTickets for help on using tickets.