Unnecessary use of swappable arguments

[tobifjellner]

In current trunk (5.2) /wp-admin/includes/file.php contains a couple of string with numbered arguments, but since there is only one placeable, it doesn't need to be numbered.

The authenticity of %1$s could not be verified as signature verification is unavailable on this system.

The authenticity of %1$s could not be verified as no signature was found.

[subrataemfluence]

@thrijith please correct the following line of code:

$home = parse_url( get_option( 'swp-admin/includes/file.php iteurl' ) ); in the patch for src/wp-includes/class-wp-http-proxy.php

[thrijith]

@subrataemfluence I have corrected that in the second patch, please check.

[SergeyBiryukov]

Hi @thrijith, thanks for the patch!

Just to clarify, <span class="code">%s</span> should not be added to the translatable string. We've been removing unnecessary HTML tags from strings for a while in some previous tickets.

The first patch looks good, excerpt for the wp-includes/class-wp-http-proxy.php change.

The translator comments above the strings should also be updated to replace 1: with %s:.

[thrijith]

Refresh patch

[thrijith]

Hi @SergeyBiryukov,

Thanks for the review. I have updated the patch.
Please let me know if something else needs to be changed in this.

[desrosj]

In 45167:

Administration: Remove unnecessary numbered placeholders.

Props: tobifjellner, thrijith.
Fixes #46824.