WordPress.org

Make WordPress Core

Opened 16 months ago

Closed 16 months ago

Last modified 14 months ago

#46826 closed defect (bug) (worksforme)

misleading translator comment

Reported by: Presskopp Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: site-health
Focuses: Cc:

Description

The string

Site information has been added to your clipboard.

has a surplus translator comment:

translators: %s: The percentage score for the tests.

Attachments (2)

46826.diff (923 bytes) - added by juiiee8487 16 months ago.
Created patch.
46826.2.diff (973 bytes) - added by juiiee8487 16 months ago.
Updated patch.

Download all attachments as: .zip

Change History (19)

#1 @Presskopp
16 months ago

..coming from

wp-admin/includes/class-wp-site-health.php:58

#2 @tobifjellner
16 months ago

  • Keywords good-first-bug added

#3 @tobifjellner
16 months ago

  • Component changed from Text Changes to Administration

@juiiee8487
16 months ago

Created patch.

#4 @juiiee8487
16 months ago

  • Keywords has-patch added; needs-patch removed

#5 @tobifjellner
16 months ago

https://core.trac.wordpress.org/attachment/ticket/46826/46826.diff just deletes the comment. But it would still need to explain the meaning of %s. Obviously, one would need to find the javascript that consumes this array and then add a comment about the format of this "score".

@juiiee8487
16 months ago

Updated patch.

#6 @mukesh27
16 months ago

  • Keywords needs-refresh added

%s us used in wp-admin/js/site-health.js js it will replace %s value with test result count number value and static %.

text suggestion:

// translators: %s: The percentage score for the tests.

Replace with

// translators: %s: Your website percentage score for the site health.

#7 @Presskopp
16 months ago

Please note that the translator comment is appearing right for the string above but it also appears for the mentioned string where it is not needed

#8 @SergeyBiryukov
16 months ago

  • Component changed from Administration to I18N

#9 @SergeyBiryukov
16 months ago

  • Keywords site-health added

#10 @SergeyBiryukov
16 months ago

The text of the comment seems fine as is, we just need to figure out why it's displayed for the wrong string.

Could be an issue with the i18n tools, similar to #30972.

#11 @afercia
16 months ago

Note: these string are now translated via wp.i18n after [45178] not sure this ticket is still relevant.

Last edited 16 months ago by SergeyBiryukov (previous) (diff)

#12 @Clorith
16 months ago

  • Keywords reporter-feedback added; has-patch removed

This has been moved out in r45178, as mentioned, could you confirm this is no longer giving the incorrect translator comment @Presskopp ? So that I'm not looking in the wrong place?

#13 follow-up: @tobifjellner
16 months ago

Strange thing. The strings for wp.a11y.speak (All site health tests have finished running.) and (Site information has been added to your clipboard.) actually do seem to be missing in the translation project...

You can check by opening any 5.2 dev Admin project, for instance:
https://translate.wordpress.org/projects/wp/dev/admin/sv/default/?filters%5Bterm%5D=site-health&filters%5Buser_login%5D=&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filter=Filter&sort%5Bby%5D=original_date_added&sort%5Bhow%5D=desc
(This happens to be Swedish.)

This ticket was mentioned in Slack in #meta-i18n by clorith. View the logs.


16 months ago

#15 in reply to: ↑ 13 @SergeyBiryukov
16 months ago

  • Keywords reporter-feedback good-first-bug needs-refresh removed
  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Replying to tobifjellner:

Strange thing. The strings for wp.a11y.speak (All site health tests have finished running.) and (Site information has been added to your clipboard.) actually do seem to be missing in the translation project...

I see them here:

I also don't see the incorrect translator comment from the ticket description now, closing as worksforme.

#16 @Presskopp
16 months ago

confirmed working now

#17 @spacedmonkey
14 months ago

  • Component changed from I18N to Site Health
Note: See TracTickets for help on using tickets.