misleading translator comment

[Presskopp]

The string

Site information has been added to your clipboard.

has a surplus translator comment:

translators: %s: The percentage score for the tests.

[Presskopp]

..coming from

wp-admin/includes/class-wp-site-health.php:58

[juiiee8487]

Created patch.

[tobifjellner]

https://core.trac.wordpress.org/attachment/ticket/46826/46826.diff just deletes the comment. But it would still need to explain the meaning of %s. Obviously, one would need to find the javascript that consumes this array and then add a comment about the format of this "score".

[juiiee8487]

Updated patch.

[mukesh27]

%s us used in wp-admin/js/site-health.js js it will replace %s value with test result count number value and static %.

text suggestion:

// translators: %s: The percentage score for the tests.

Replace with

// translators: %s: Your website percentage score for the site health.

[Presskopp]

Please note that the translator comment is appearing right for the string above but it also appears for the mentioned string where it is not needed

[SergeyBiryukov]

The text of the comment seems fine as is, we just need to figure out why it's displayed for the wrong string.

Could be an issue with the i18n tools, similar to #30972.

[afercia]

Note: these string are now translated via wp.i18n after https://core.trac.wordpress.org/changeset/45178 not sure this ticket is still relevant.

[Clorith]

This has been moved out in r45178, as mentioned, could you confirm this is no longer giving the incorrect translator comment @Presskopp ? So that I'm not looking in the wrong place?

[tobifjellner]

Strange thing. The strings for wp.a11y.speak (All site health tests have finished running.) and (Site information has been added to your clipboard.) actually do seem to be missing in the translation project...

You can check by opening any 5.2 dev Admin project, for instance:
​https://translate.wordpress.org/projects/wp/dev/admin/sv/default/?filters%5Bterm%5D=site-health&filters%5Buser_login%5D=&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filter=Filter&sort%5Bby%5D=original_date_added&sort%5Bhow%5D=desc
(This happens to be Swedish.)

[SergeyBiryukov]

Replying to tobifjellner:

Strange thing. The strings for wp.a11y.speak (All site health tests have finished running.) and (Site information has been added to your clipboard.) actually do seem to be missing in the translation project...

I see them here:

• ​All site health tests have finished running.
• ​Site information has been added to your clipboard.

I also don't see the incorrect translator comment from the ticket description now, closing as worksforme.

[Presskopp]

confirmed working now