Context Navigation

← Previous Ticket
Next Ticket →

#4683 closed defect (bug) (fixed)

category dropdown javascript wrong location after moved blog

Reported by:	Pastinakel	Owned by:
Priority:	normal	Milestone:	2.2.2
Component:	General	Version:	2.2.1
Severity:	normal	Keywords:	category dropdown moved has-patch
Cc:		Focuses:

Description

After moving the blog address to a different location from the wordpress address, the categories dropdown gives a 404 because it uses a wrong value.

Condition:
This happens only when the location of wordpress is not the same as the blog's location, i.e.

get_option('siteurl') != get_option('home')

Example:
Blog: http://www.mysite.net/
WP: http://www.mysite.net/wordpress/
Dropdown points to: http://www.mysite.net/wordpress/?cat=1
Dropdown should point to: http://www.mysite.net/?cat=1

Caused by:
wp-includes/widgets.php:633

location.href = "<?php echo get_option('siteurl'); ?>/?cat="+dropdown.options[dropdown.selectedIndex].value;

Fix:
wp-includes/widgets.php:633

location.href = "<?php echo get_option('home'); ?>/?cat="+dropdown.options[dropdown.selectedIndex].value;

Attachments (1)

widgets.php.diff (249 bytes ) - added by Pastinakel 19 years ago.: diff

Download all attachments as: .zip

Change History (6)

@Pastinakel
19 years ago

Attachment widgets.php.diff added

diff

#1 @foolswisdom
19 years ago

Keywords has-patch added
Milestone → 2.3 (trunk)

#2 @markjaquith
19 years ago

Pastinakel, thanks for the report and the patch! In the future could you please provide us with unified diffs make from the root WP directory?

If you use Subversion, you can just:

cd wordpress
svn di > ~/desktop/patch.diff

#3 @markjaquith
19 years ago

Resolution → fixed
Status new → closed

(In [5823]) Use "home," not "siteurl" for widget dropdown category URLs. Props Pastinakel. fixes #4683 for trunk

#4 @markjaquith
19 years ago

Milestone 2.3 (trunk) → 2.2.2
Resolution fixed
Status closed → reopened

#5 @markjaquith
19 years ago

Resolution → fixed
Status reopened → closed

(In [5824]) Use "home," not "siteurl" for widget dropdown category URLs. Props Pastinakel. fixes #4683 for 2.2.x

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#4683 closed defect (bug) (fixed)

category dropdown javascript wrong location after moved blog

Description

Attachments (1)

Change History (6)

@Pastinakel 19 years ago

#1 @foolswisdom 19 years ago

#2 @markjaquith 19 years ago

#3 @markjaquith 19 years ago

#4 @markjaquith 19 years ago

#5 @markjaquith 19 years ago