WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #46830, comment 3


Ignore:
Timestamp:
09/06/2019 08:13:52 AM (2 years ago)
Author:
garrett-eclipse
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #46830, comment 3

    initial v1  
    33Reviewing the code everything looked very well written thank you. In php unit tests I've seen ticket references as `@ticket XXXXX` but I'm not sure if that's also the standard with JS (referring to your `@see` reference).
    44
    5 @audrasjb would you mind taking a final review this works nicely and applies cleanly.
     5@audrasjb would you mind taking a final review this works nicely and applies cleanly. I feel it's ready to commit but Customizer is your component ;)
    66
    77P.S. While testing I found the check icon is lost if you click 'Add Items' to open/close the drawer. I've opened [https://core.trac.wordpress.org/ticket/47990 47990] to look into keep that persistent.