Opened 6 years ago
Closed 6 years ago
#46841 closed defect (bug) (fixed)
References to htaccess should be preceded with the dot to denote it's a hidden file - .htaccess
Reported by: | garrett-eclipse | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.2 | Priority: | normal |
Severity: | normal | Version: | 5.2 |
Component: | Text Changes | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Hello,
The references to htaccess introduced in the class-wp-debug-data.php should be prefixed with the dot to indicate that it's a hidden file, reference;
https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-debug-data.php#L603-L606
Referring to the Glossary;
".htaccess is a hidden file in Unix/Linux (as dictated by the preceding period '.'),"
Reference - https://codex.wordpress.org/Glossary#.htaccess
As well in all core references, it's noted as .htaccess. Just noticed while translating.
Cheers
Attachments (4)
Change History (13)
#1
@
6 years ago
- Component changed from I18N to Text Changes
- Keywords has-patch added
- Milestone changed from Awaiting Review to 5.2
There are a few places in core where we use a placeholder instead to replace it with '<code>.htaccess</code>'
. Can we do this here too?
#2
@
6 years ago
The labels and values are escaped with esc_html()
in src/wp-admin/site-health-info.php
.
Other places in that table there use wp_kses()
, which potentially could be a bit slow when applied to all the debug data.
#4
follow-up:
↓ 5
@
6 years ago
Let's focus on the Site Health part first before doing a search and replace on unrelated docs :-)
#5
in reply to:
↑ 4
@
6 years ago
Sure. Sorry for jumping in! I thought otherwise, i.e. this change might required to be implemented wherever it is present!
Replying to swissspidy:
Let's focus on the Site Health part first before doing a search and replace on unrelated docs :-)
#6
@
6 years ago
- Keywords commit added
The original patch no longer applied cleanly, so 46841.3.diff is a refresh of that, which only focuses on Site Health
pages
Prefix new htaccess references with the dot to make them .htaccess 'hidden files'