WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#46847 closed defect (bug) (fixed)

Site Health: i18n of "Copied!"

Reported by: soean's profile Soean Owned by: desrosj's profile desrosj
Milestone: 5.2 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: site-health has-patch commit
Focuses: Cc:

Description

The string 'Copied!' is not ready for translation:

<span class="success" aria-hidden="true">Copied!</span>

​https://github.com/WordPress/wordpress-develop/blob/e0041a579400ea9b718148a34a6ff7da8781f25f/src/wp-admin/site-health-info.php#L90

Attachments (3)

46847.diff​ (766 bytes) - added by mukesh27 5 years ago.
Patch.
46847.2.diff​ (1.1 KB) - added by mukesh27 5 years ago.
Updated patch.
46847.3.diff​ (1.2 KB) - added by davidbaumwald 5 years ago.
Patch with fix

Download all attachments as: .zip

Change History (11)

#1 @Soean
5 years ago

  • Keywords site-health needs-patch added
  • Version set to trunk

#2 @swissspidy
5 years ago

  • Milestone changed from Awaiting Review to 5.2

@mukesh27
5 years ago

Patch.

#3 @mukesh27
5 years ago

  • Keywords has-patch added; needs-patch removed

#4 @Soean
5 years ago

@mukesh27 Thanks for the patch, the string is also in line 95. Can you add it?

@mukesh27
5 years ago

Updated patch.

@davidbaumwald
5 years ago

Patch with fix

#5 @afercia
5 years ago

Related: #46683.

#6 @desrosj
5 years ago

  • Keywords commit added
  • Owner set to desrosj
  • Status changed from new to assigned

#7 @desrosj
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45155:

Site Health: Add missing i18n for “Copied!” string.

Props: Soean, mukesh27, davidbaumwald.
Fixes #46847.

#8 @spacedmonkey
5 years ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.